From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@skynet.ie>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
Jeremy Higdon <jeremy@sgi.com>, Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org,
Balbir Singh <balbir@linux.vnet.ibm.com>,
linux-ia64@vger.kernel.org, Christoph Lameter <clameter@sgi.com>,
linux-mm@kvack.org
Subject: [PATCH] Fix find_next_best_node (Re: [BUG] 2.6.23-rc3-mm1 Kernel panic - not syncing: DMA: Memory would be corrupted)
Date: Fri, 24 Aug 2007 15:53:25 +0900 [thread overview]
Message-ID: <20070824153945.3C75.Y-GOTO@jp.fujitsu.com> (raw)
In-Reply-To: <20070823142133.9359a1ce.akpm@linux-foundation.org>
I found find_next_best_node() was wrong.
I confirmed boot up by the following patch.
Mel-san, Kamalesh-san, could you try this?
Bye.
---
Fix decision of memoryless node in find_next_best_node().
This can be cause of SW-IOMMU's allocation failure.
This patch is for 2.6.23-rc3-mm1.
Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: current/mm/page_alloc.c
===================================================================
--- current.orig/mm/page_alloc.c 2007-08-24 16:03:17.000000000 +0900
+++ current/mm/page_alloc.c 2007-08-24 16:04:06.000000000 +0900
@@ -2136,7 +2136,7 @@ static int find_next_best_node(int node,
* Note: N_HIGH_MEMORY state not guaranteed to be
* populated yet.
*/
- if (pgdat->node_present_pages)
+ if (!pgdat->node_present_pages)
continue;
/* Don't want a node to appear more than once */
--
Yasunori Goto
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-08-24 6:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <617E1C2C70743745A92448908E030B2A023B2FD5@scsmsx411.amr.corp.intel.com>
[not found] ` <20070823091556.GA18456@skynet.ie>
[not found] ` <20070823221005.0D76.Y-GOTO@jp.fujitsu.com>
[not found] ` <617E1C2C70743745A92448908E030B2A023EB020@scsmsx411.amr.corp.intel.com>
2007-08-23 21:21 ` [BUG] 2.6.23-rc3-mm1 Kernel panic - not syncing: DMA: Memory would be corrupted Andrew Morton
2007-08-24 6:53 ` Yasunori Goto [this message]
2007-08-24 14:52 ` [PATCH] Fix find_next_best_node (Re: [BUG] 2.6.23-rc3-mm1 Kernel panic - not syncing: DMA: Memory would be corrupted) Mel Gorman
2007-08-24 15:49 ` Lee Schermerhorn
2007-08-24 17:00 ` Christoph Lameter
2007-08-24 18:03 ` Lee Schermerhorn
2007-08-24 18:08 ` Christoph Lameter
2007-08-24 17:02 ` Christoph Lameter
2007-08-24 16:46 ` Kamalesh Babulal
2007-08-28 22:41 ` Adam Litke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070824153945.3C75.Y-GOTO@jp.fujitsu.com \
--to=y-goto@jp.fujitsu.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=clameter@sgi.com \
--cc=jeremy@sgi.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@skynet.ie \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox