linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: mel@skynet.ie (Mel Gorman)
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org,
	Balbir Singh <balbir@linux.vnet.ibm.com>,
	Christoph Lameter <clameter@sgi.com>,
	linux-mm@kvack.org
Subject: Re: [BUG] 2.6.23-rc3-mm1 kernel BUG at mm/page_alloc.c:2876!
Date: Thu, 23 Aug 2007 14:07:32 +0100	[thread overview]
Message-ID: <20070823130732.GC18456@skynet.ie> (raw)
In-Reply-To: <20070822135024.dde8ef5a.akpm@linux-foundation.org>

On (22/08/07 13:50), Andrew Morton didst pronounce:
> On Wed, 22 Aug 2007 13:48:00 -0700
> Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> > This:
> > 
> > --- a/mm/page_alloc.c~a
> > +++ a/mm/page_alloc.c
> > @@ -2814,6 +2814,8 @@ static int __cpuinit process_zones(int c
> >  	return 0;
> >  bad:
> >  	for_each_zone(dzone) {
> > +		if (!populated_zone(zone))
> > +			continue;		
> >  		if (dzone == zone)
> >  			break;
> >  		kfree(zone_pcp(dzone, cpu));
> > _
> > 
> > might help avoid the crash
> 
> err, make that
> 

We're already in the error path at this point and it's going to blow up.
The real problem is kmalloc_node() returning NULL for whatever reason.

> --- a/mm/page_alloc.c~a
> +++ a/mm/page_alloc.c
> @@ -2814,6 +2814,8 @@ static int __cpuinit process_zones(int c
>  	return 0;
>  bad:
>  	for_each_zone(dzone) {
> +		if (!populated_zone(dzone))
> +			continue;
>  		if (dzone == zone)
>  			break;
>  		kfree(zone_pcp(dzone, cpu));
> _
> 
> 

-- 
-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-08-23 13:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <46CC9A7A.2030404@linux.vnet.ibm.com>
2007-08-22 20:48 ` Andrew Morton
2007-08-22 20:50   ` Andrew Morton
2007-08-23 13:07     ` Mel Gorman [this message]
2007-08-23 17:17       ` Kamalesh Babulal
2007-08-23 20:05         ` Christoph Lameter
2007-08-24  6:15           ` Kamalesh Babulal
2007-08-24  8:58             ` Mel Gorman
2007-08-24 16:54             ` Christoph Lameter
2007-08-22 21:09   ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070823130732.GC18456@skynet.ie \
    --to=mel@skynet.ie \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=clameter@sgi.com \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox