From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: clameter@sgi.com, anton@samba.org, lee.schermerhorn@hp.com,
wli@holomorphy.com, linux-mm@kvack.org
Subject: Re: [RFC][PATCH 4/4] hugetlb: add per-node nr_hugepages sysfs attribute
Date: Wed, 22 Aug 2007 14:17:28 -0700 [thread overview]
Message-ID: <20070822211728.GA5542@us.ibm.com> (raw)
In-Reply-To: <1187027746.2521.48.camel@localhost>
On 13.08.2007 [10:55:46 -0700], Dave Hansen wrote:
> On Wed, 2007-08-08 at 17:52 -0700, Nishanth Aravamudan wrote:
> >
> > +#ifdef CONFIG_NUMA
> > +int hugetlb_register_node(struct node *);
> > +void hugetlb_unregister_node(struct node *);
> > +#else
> > +#define hugetlb_register_node(node) 0
> > +#define hugetlb_unregister_node(node) ((void)0)
> > +#endif
>
> This is to keep someone from doing:
>
> ret = hugetlb_unregister_node(node);
>
> ?
>
> I think it's a little more standard to do:
>
> #define hugetlb_unregister_node(node) do {} while(0)
That's a good point. Now that I'm back from vacation, I'll make this
adjustment.
Thanks,
Nish
--
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2007-08-22 21:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 0:47 [RFC][PATCH 1/4] hugetlb: search harder for memory in alloc_fresh_huge_page() Nishanth Aravamudan
2007-08-09 0:49 ` [RFC][PATCH 2/4] hugetlb: fix pool allocation with empty nodes Nishanth Aravamudan
2007-08-09 0:51 ` [RFC][PATCH 3/4] hugetlb: interleave dequeueing of huge pages Nishanth Aravamudan
2007-08-09 0:52 ` [RFC][PATCH 4/4] hugetlb: add per-node nr_hugepages sysfs attribute Nishanth Aravamudan
2007-08-13 17:55 ` Dave Hansen
2007-08-22 21:17 ` Nishanth Aravamudan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070822211728.GA5542@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=anton@samba.org \
--cc=clameter@sgi.com \
--cc=haveblue@us.ibm.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-mm@kvack.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox