From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Mel Gorman <mel@skynet.ie>
Cc: Andy Whitcroft <apw@shadowen.org>, Andrew Morton <akpm@osdl.org>,
Christoph Lameter <clameter@sgi.com>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [Patch](memory hotplug) Hot-add with sparsemem-vmemmap
Date: Wed, 22 Aug 2007 10:28:54 +0900 [thread overview]
Message-ID: <20070822095447.05E5.Y-GOTO@jp.fujitsu.com> (raw)
In-Reply-To: <20070821125922.GG11329@skynet.ie>
> > Index: vmemmap/mm/sparse-vmemmap.c
> > ===================================================================
> > --- vmemmap.orig/mm/sparse-vmemmap.c 2007-08-10 20:17:19.000000000 +0900
> > +++ vmemmap/mm/sparse-vmemmap.c 2007-08-10 21:12:54.000000000 +0900
> > @@ -170,7 +170,7 @@ int __meminit vmemmap_populate(struct pa
> > }
> > #endif /* !CONFIG_ARCH_POPULATES_SPARSEMEM_VMEMMAP */
> >
> > -struct page __init *sparse_early_mem_map_populate(unsigned long pnum, int nid)
> > +struct page *sparse_mem_map_populate(unsigned long pnum, int nid)
>
> __meminit here instead of __init?
Ah, Yes. Thanks. I'll fix it.
>
> > Index: vmemmap/mm/sparse.c
> > ===================================================================
> > --- vmemmap.orig/mm/sparse.c 2007-08-10 20:17:19.000000000 +0900
> > +++ vmemmap/mm/sparse.c 2007-08-10 21:21:01.000000000 +0900
> > @@ -259,7 +259,7 @@ static unsigned long *sparse_early_usema
> > }
> >
> > #ifndef CONFIG_SPARSEMEM_VMEMMAP
> > -struct page __init *sparse_early_mem_map_populate(unsigned long pnum, int nid)
> > +struct page __init *sparse_mem_map_populate(unsigned long pnum, int nid)
>
> __meminit again possibly.
Here should use __init. It is called at boot time and uses
alloc_bootmem().
> > #ifdef CONFIG_MEMORY_HOTPLUG
> > +#ifdef CONFIG_SPARSEMEM_VMEMMAP
> > +static inline struct page *kmalloc_section_memmap(unsigned long pnum, int nid,
> > + unsigned long nr_pages)
> > +{
> > + return sparse_mem_map_populate(pnum, nid);
> > +}
>
> In the other version of __kmalloc_section_memmap(), pages get allocated
> from alloc_pages() and it's obvious it's allocated there. A one line
> comment saying that sparse_mem_map_populate() will make the necessary
> allocations eventually would be nice.
>
> Not a big deal though.
Ah, Ok. I'll add its comment.
Thanks.
--
Yasunori Goto
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-08-22 1:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 7:08 Yasunori Goto
2007-08-20 18:56 ` Christoph Lameter
2007-08-21 1:23 ` Yasunori Goto
2007-08-21 12:59 ` Mel Gorman
2007-08-22 1:28 ` Yasunori Goto [this message]
2007-08-30 11:04 ` [Patch](memory hotplug) Tiny update for hot-add " Yasunori Goto
2007-08-31 21:00 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070822095447.05E5.Y-GOTO@jp.fujitsu.com \
--to=y-goto@jp.fujitsu.com \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
--cc=mel@skynet.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox