From: mel@skynet.ie (Mel Gorman)
To: Andi Kleen <ak@suse.de>
Cc: Christoph Lameter <clameter@sgi.com>,
Lee.Schermerhorn@hp.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 6/6] Do not use FASTCALL for __alloc_pages_nodemask()
Date: Tue, 21 Aug 2007 11:25:35 +0100 [thread overview]
Message-ID: <20070821102535.GF29794@skynet.ie> (raw)
In-Reply-To: <200708181451.47219.ak@suse.de>
On (18/08/07 14:51), Andi Kleen didst pronounce:
> On Friday 17 August 2007 23:07:33 Christoph Lameter wrote:
> > On Fri, 17 Aug 2007, Mel Gorman wrote:
> >
> > > Opinions as to why FASTCALL breaks on one machine are welcome.
> >
> > Could we get rid of FASTCALL? AFAIK the compiler should automatically
> > choose the right calling convention?
>
> It was a nop for some time because register parameters are always enabled
> on i386 and AFAIK no other architectures ever used it. Some out of tree
> trees some to disable register parameters though, but that's not
> really a concern.
>
You're right. It now makes even less sense why it was a PPC64 machine that
exhibited the problem. It should have made no difference at all.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2007-08-21 10:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 20:16 [PATCH 0/6] Use one zonelist per node instead of multiple zonelists v4 Mel Gorman
2007-08-17 20:17 ` [PATCH 1/6] Use zonelists instead of zones when direct reclaiming pages Mel Gorman
2007-08-17 20:17 ` [PATCH 2/6] Use one zonelist that is filtered instead of multiple zonelists Mel Gorman
2007-08-17 20:59 ` Christoph Lameter
2007-08-21 8:51 ` Mel Gorman
2007-08-17 20:17 ` [PATCH 3/6] Embed zone_id information within the zonelist->zones pointer Mel Gorman
2007-08-17 21:02 ` Christoph Lameter
2007-08-21 8:54 ` Mel Gorman
2007-08-17 20:18 ` [PATCH 4/6] Record how many zones can be safely skipped in the zonelist Mel Gorman
2007-08-17 21:03 ` Christoph Lameter
2007-08-21 8:58 ` Mel Gorman
2007-08-17 20:18 ` [PATCH 5/6] Filter based on a nodemask as well as a gfp_mask Mel Gorman
2007-08-17 21:29 ` Christoph Lameter
2007-08-21 9:12 ` Mel Gorman
2007-08-17 20:18 ` [PATCH 6/6] Do not use FASTCALL for __alloc_pages_nodemask() Mel Gorman
2007-08-17 21:07 ` Christoph Lameter
2007-08-18 12:51 ` Andi Kleen
2007-08-21 10:25 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070821102535.GF29794@skynet.ie \
--to=mel@skynet.ie \
--cc=Lee.Schermerhorn@hp.com \
--cc=ak@suse.de \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox