From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 21 Aug 2007 10:23:30 +0900 From: Yasunori Goto Subject: Re: [Patch](memory hotplug) Hot-add with sparsemem-vmemmap In-Reply-To: References: <20070817155908.7D91.Y-GOTO@jp.fujitsu.com> Message-Id: <20070821093414.AE00.Y-GOTO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Andy Whitcroft , Andrew Morton , Mel Gorman , linux-mm List-ID: > On Fri, 17 Aug 2007, Yasunori Goto wrote: > > > Todo: # Even if this patch is applied, the message "[xxxx-xxxx] potential > > offnode page_structs" is displayed. To allocate memmap on its node, > > memmap (and pgdat) must be initialized itself like chicken and > > egg relationship. > > Hmmmm.... You need to create something like the bootmem allocator? Right. I suppose it may be better. > > Or relocate the memory map later. I suppose relocation will be messy way..... > > Or just add a small piece of memory first so that only one memmap block is > placed off line? I'm not sure what you mean about "add small piece". Do you mean reservation for memmap/pgdat block first? Then this is second choice. Even if either is chosen, kernel must remember memmap's place until unplug. I'll try easier way. > > > # vmemmap_unpopulate will be necessary for followings. > > - For cancel hot-add due to error. > > - For unplug. > > > > Please comment. > > Looks fine to me. Thanks :-) -- Yasunori Goto -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org