linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andy Whitcroft <apw@shadowen.org>, Andrew Morton <akpm@osdl.org>,
	Mel Gorman <mel@csn.ul.ie>, linux-mm <linux-mm@kvack.org>
Subject: Re: [Patch](memory hotplug) Hot-add with sparsemem-vmemmap
Date: Tue, 21 Aug 2007 10:23:30 +0900	[thread overview]
Message-ID: <20070821093414.AE00.Y-GOTO@jp.fujitsu.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0708201154280.28863@schroedinger.engr.sgi.com>

> On Fri, 17 Aug 2007, Yasunori Goto wrote:
> 
> > Todo: # Even if this patch is applied, the message "[xxxx-xxxx] potential
> >         offnode page_structs" is displayed. To allocate memmap on its node,
> >         memmap (and pgdat) must be initialized itself like chicken and
> >         egg relationship.
> 
> Hmmmm.... You need to create something like the bootmem allocator?

Right. I suppose it may be better.

> 
> Or relocate the memory map later.

I suppose relocation will be messy way.....

> 
> Or just add a small piece of memory first so that only one memmap block is 
> placed off line?

I'm not sure what you mean about "add small piece".
Do you mean reservation for memmap/pgdat block first?
Then this is second choice.

Even if either is chosen, kernel must remember memmap's place until
unplug. I'll try easier way.

>  
> >       # vmemmap_unpopulate will be necessary for followings.
> >          - For cancel hot-add due to error.
> >          - For unplug.
> > 
> > Please comment.
> 
> Looks fine to me.

Thanks :-)


-- 
Yasunori Goto 


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-08-21  1:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-17  7:08 Yasunori Goto
2007-08-20 18:56 ` Christoph Lameter
2007-08-21  1:23   ` Yasunori Goto [this message]
2007-08-21 12:59 ` Mel Gorman
2007-08-22  1:28   ` Yasunori Goto
2007-08-30 11:04     ` [Patch](memory hotplug) Tiny update for hot-add " Yasunori Goto
2007-08-31 21:00       ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070821093414.AE00.Y-GOTO@jp.fujitsu.com \
    --to=y-goto@jp.fujitsu.com \
    --cc=akpm@osdl.org \
    --cc=apw@shadowen.org \
    --cc=clameter@sgi.com \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox