* [PATCH] calculation of pgoff in do_linear_fault() uses mixed units
@ 2007-08-15 17:43 Dean Nelson
2007-08-16 2:52 ` Nick Piggin
0 siblings, 1 reply; 3+ messages in thread
From: Dean Nelson @ 2007-08-15 17:43 UTC (permalink / raw)
To: akpm; +Cc: npiggin, linux-mm, linux-kernel
The calculation of pgoff in do_linear_fault() should use PAGE_SHIFT and not
PAGE_CACHE_SHIFT since vma->vm_pgoff is in units of PAGE_SIZE and not
PAGE_CACHE_SIZE. At the moment linux/pagemap.h has PAGE_CACHE_SHIFT defined
as PAGE_SHIFT, but should that ever change this calculation would break.
Signed-off-by: Dean Nelson <dcn@sgi.com>
Index: linux-2.6/mm/memory.c
===================================================================
--- linux-2.6.orig/mm/memory.c 2007-08-14 06:42:18.322378070 -0500
+++ linux-2.6/mm/memory.c 2007-08-15 12:30:51.621604739 -0500
@@ -2465,7 +2465,7 @@
int write_access, pte_t orig_pte)
{
pgoff_t pgoff = (((address & PAGE_MASK)
- - vma->vm_start) >> PAGE_CACHE_SHIFT) + vma->vm_pgoff;
+ - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff;
unsigned int flags = (write_access ? FAULT_FLAG_WRITE : 0);
return __do_fault(mm, vma, address, page_table, pmd, pgoff,
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] calculation of pgoff in do_linear_fault() uses mixed units
2007-08-15 17:43 [PATCH] calculation of pgoff in do_linear_fault() uses mixed units Dean Nelson
@ 2007-08-16 2:52 ` Nick Piggin
0 siblings, 0 replies; 3+ messages in thread
From: Nick Piggin @ 2007-08-16 2:52 UTC (permalink / raw)
To: Dean Nelson; +Cc: akpm, linux-mm, linux-kernel
On Wed, Aug 15, 2007 at 12:43:26PM -0500, Dean Nelson wrote:
> The calculation of pgoff in do_linear_fault() should use PAGE_SHIFT and not
> PAGE_CACHE_SHIFT since vma->vm_pgoff is in units of PAGE_SIZE and not
> PAGE_CACHE_SIZE. At the moment linux/pagemap.h has PAGE_CACHE_SHIFT defined
> as PAGE_SHIFT, but should that ever change this calculation would break.
>
> Signed-off-by: Dean Nelson <dcn@sgi.com>
>
Acked-by: Nick Piggin <npiggin@suse.de>
>
> Index: linux-2.6/mm/memory.c
> ===================================================================
> --- linux-2.6.orig/mm/memory.c 2007-08-14 06:42:18.322378070 -0500
> +++ linux-2.6/mm/memory.c 2007-08-15 12:30:51.621604739 -0500
> @@ -2465,7 +2465,7 @@
> int write_access, pte_t orig_pte)
> {
> pgoff_t pgoff = (((address & PAGE_MASK)
> - - vma->vm_start) >> PAGE_CACHE_SHIFT) + vma->vm_pgoff;
> + - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff;
> unsigned int flags = (write_access ? FAULT_FLAG_WRITE : 0);
>
> return __do_fault(mm, vma, address, page_table, pmd, pgoff,
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] calculation of pgoff in do_linear_fault() uses mixed units
@ 2007-08-14 11:36 Dean Nelson
0 siblings, 0 replies; 3+ messages in thread
From: Dean Nelson @ 2007-08-14 11:36 UTC (permalink / raw)
To: npiggin, linux-kernel, linux-mm
The calculation of pgoff in do_linear_fault() should use PAGE_SHIFT and not
PAGE_CACHE_SHIFT since vma->vm_pgoff is in units of PAGE_SIZE and not
PAGE_CACHE_SIZE. At the moment linux/pagemap.h has PAGE_CACHE_SHIFT defined
as PAGE_SHIFT, but should that ever change this calculation would break.
Signed-off-by: Dean Nelson <dcn@sgi.com>
Index: linux-2.6/mm/memory.c
===================================================================
--- linux-2.6.orig/mm/memory.c 2007-08-10 09:11:32.000000000 -0500
+++ linux-2.6/mm/memory.c 2007-08-14 06:26:11.731319983 -0500
@@ -2466,7 +2466,7 @@
int write_access, pte_t orig_pte)
{
pgoff_t pgoff = (((address & PAGE_MASK)
- - vma->vm_start) >> PAGE_CACHE_SHIFT) + vma->vm_pgoff;
+ - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff;
unsigned int flags = (write_access ? FAULT_FLAG_WRITE : 0);
return __do_fault(mm, vma, address, page_table, pmd, pgoff,
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-16 2:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-15 17:43 [PATCH] calculation of pgoff in do_linear_fault() uses mixed units Dean Nelson
2007-08-16 2:52 ` Nick Piggin
-- strict thread matches above, loose matches on Subject: below --
2007-08-14 11:36 Dean Nelson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox