From: yamamoto@valinux.co.jp (YAMAMOTO Takashi)
To: svaidy@linux.vnet.ibm.com
Cc: a.p.zijlstra@chello.nl, dhaval@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
ebiederm@xmission.com, containers@lists.osdl.org,
akpm@linux-foundation.org, xemul@openvz.org, menage@google.com,
balbir@linux.vnet.ibm.com
Subject: Re: [-mm PATCH 4/9] Memory controller memory accounting (v4)
Date: Wed, 15 Aug 2007 17:44:53 +0900 (JST) [thread overview]
Message-ID: <20070815084454.09B061BF982@siro.lan> (raw)
In-Reply-To: Your message of "Tue, 31 Jul 2007 18:14:26 +0530" <46AF2EAA.2080703@linux.vnet.ibm.com>
> YAMAMOTO Takashi wrote:
> >> + lock_meta_page(page);
> >> + /*
> >> + * Check if somebody else beat us to allocating the meta_page
> >> + */
> >> + race_mp = page_get_meta_page(page);
> >> + if (race_mp) {
> >> + kfree(mp);
> >> + mp = race_mp;
> >> + atomic_inc(&mp->ref_cnt);
> >> + res_counter_uncharge(&mem->res, 1);
> >> + goto done;
> >> + }
> >
> > i think you need css_put here.
>
> Thats correct. We do need css_put in this path.
>
> Thanks,
> Vaidy
v5 still seems to have the problem.
YAMAMOTO Takashi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-08-15 8:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-27 20:09 [-mm PATCH 0/9] Memory controller introduction (v4) Balbir Singh
2007-07-27 20:09 ` [-mm PATCH 1/9] Memory controller resource counters (v4) Balbir Singh
2007-07-27 20:09 ` [-mm PATCH 2/9] Memory controller containers setup (v4) Balbir Singh
2007-07-27 20:10 ` [-mm PATCH 3/9] Memory controller accounting " Balbir Singh
2007-07-27 20:10 ` [-mm PATCH 4/9] Memory controller memory accounting (v4) Balbir Singh
2007-07-31 3:38 ` YAMAMOTO Takashi
2007-07-31 12:44 ` Vaidyanathan Srinivasan
2007-08-15 8:44 ` YAMAMOTO Takashi [this message]
2007-08-15 10:02 ` Balbir Singh
2007-07-27 20:10 ` [-mm PATCH 5/9] Memory controller task migration (v4) Balbir Singh
2007-07-27 20:10 ` [-mm PATCH 6/9] Memory controller add per container LRU and reclaim (v4) Balbir Singh
2007-07-30 13:37 ` Dhaval Giani
2007-07-30 13:59 ` Peter Zijlstra
2007-07-30 14:28 ` Gautham R Shenoy
2007-07-31 5:14 ` YAMAMOTO Takashi
2007-07-31 12:55 ` Vaidyanathan Srinivasan
2007-08-07 18:30 ` Vaidyanathan Srinivasan
2007-07-27 20:10 ` [-mm PATCH 7/9] Memory controller OOM handling (v4) Balbir Singh
2007-07-27 20:11 ` [-mm PATCH 8/9] Memory controller add switch to control what type of pages to limit (v4) Balbir Singh
2007-08-13 0:33 ` YAMAMOTO Takashi
2007-08-13 5:38 ` Balbir Singh
2007-08-13 6:04 ` YAMAMOTO Takashi
2007-08-13 6:17 ` Balbir Singh
2007-07-27 20:11 ` [-mm PATCH 9/9] Memory controller make page_referenced() container aware (v4) Balbir Singh
2007-08-08 3:51 ` [-mm PATCH 0/9] Memory controller introduction (v4) KAMEZAWA Hiroyuki
2007-08-08 7:51 ` KAMEZAWA Hiroyuki
2007-08-10 4:49 ` Vaidyanathan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070815084454.09B061BF982@siro.lan \
--to=yamamoto@valinux.co.jp \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.osdl.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox