linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mel@csn.ul.ie>
To: Lee.Schermerhorn@hp.com, ak@suse.de, clameter@sgi.com
Cc: Mel Gorman <mel@csn.ul.ie>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH 4/4] Apply MPOL_BIND policy to two highest zones when highest is ZONE_MOVABLE
Date: Thu,  9 Aug 2007 22:07:36 +0100 (IST)	[thread overview]
Message-ID: <20070809210736.14702.36541.sendpatchset@skynet.skynet.ie> (raw)
In-Reply-To: <20070809210616.14702.73376.sendpatchset@skynet.skynet.ie>

The NUMA layer only supports the MPOL_BIND NUMA policy for the highest
zone. When ZONE_MOVABLE is configured with kernelcore=, the the highest
zone becomes ZONE_MOVABLE. The result is that the bind policy policies is
only applied to allocations like anonymous pages and page cache allocated
from ZONE_MOVABLE when the zone is used.

This patch applies policies to the two highest zones when the highest zone
is ZONE_MOVABLE. As ZONE_MOVABLE consists of pages from the highest "real"
zone, these two zones are equivalent in policy terms.

Signed-off-by: Mel Gorman <mel@csn.ul.ie>
---

 include/linux/mempolicy.h |    2 +-
 mm/mempolicy.c            |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.23-rc1-mm2-015_zoneid_zonelist/include/linux/mempolicy.h linux-2.6.23-rc1-mm2-020_treat_movable_highest/include/linux/mempolicy.h
--- linux-2.6.23-rc1-mm2-015_zoneid_zonelist/include/linux/mempolicy.h	2007-08-09 15:01:36.000000000 +0100
+++ linux-2.6.23-rc1-mm2-020_treat_movable_highest/include/linux/mempolicy.h	2007-08-09 15:52:23.000000000 +0100
@@ -157,7 +157,7 @@ extern enum zone_type policy_zone;
 
 static inline void check_highest_zone(enum zone_type k)
 {
-	if (k > policy_zone)
+	if (k > policy_zone && k != ZONE_MOVABLE)
 		policy_zone = k;
 }
 
diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.23-rc1-mm2-015_zoneid_zonelist/mm/mempolicy.c linux-2.6.23-rc1-mm2-020_treat_movable_highest/mm/mempolicy.c
--- linux-2.6.23-rc1-mm2-015_zoneid_zonelist/mm/mempolicy.c	2007-08-09 18:33:51.000000000 +0100
+++ linux-2.6.23-rc1-mm2-020_treat_movable_highest/mm/mempolicy.c	2007-08-09 18:33:42.000000000 +0100
@@ -151,7 +151,7 @@ static struct zonelist *bind_zonelist(no
 	   lower zones etc. Avoid empty zones because the memory allocator
 	   doesn't like them. If you implement node hot removal you
 	   have to fix that. */
-	k = policy_zone;
+	k = MAX_NR_ZONES - 1;
 	while (1) {
 		for_each_node_mask(nd, *nodes) { 
 			struct zone *z = &NODE_DATA(nd)->node_zones[k];

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2007-08-09 21:07 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-09 21:06 [PATCH 0/4] Use one zonelist per node instead of multiple zonelists v3 Mel Gorman
2007-08-09 21:06 ` [PATCH 1/4] Use zonelists instead of zones when direct reclaiming pages Mel Gorman
2007-08-09 21:19   ` Christoph Lameter
2007-08-09 21:06 ` [PATCH 2/4] Use one zonelist that is filtered instead of multiple zonelists Mel Gorman
2007-08-09 21:27   ` Christoph Lameter
2007-08-09 21:07 ` [PATCH 3/4] Embed zone_id information within the zonelist->zones pointer Mel Gorman
2007-08-09 21:37   ` Christoph Lameter
2007-08-09 23:33     ` Mel Gorman
2007-08-10  1:44       ` Christoph Lameter
2007-08-10 10:47         ` Mel Gorman
2007-08-10 17:37           ` Christoph Lameter
2007-08-10 18:13             ` Andi Kleen
2007-08-10 19:02               ` Christoph Lameter
2007-08-11  1:04                 ` Andi Kleen
2007-08-13 21:25                   ` Christoph Lameter
2007-08-13 22:50                     ` Andi Kleen
2007-08-13 22:00                       ` Christoph Lameter
2007-08-13 22:58                         ` Andi Kleen
2007-08-13 22:09                           ` Christoph Lameter
2007-08-13 23:08                             ` Andi Kleen
2007-08-13 22:22                               ` Christoph Lameter
2007-08-13 23:42                                 ` Andi Kleen
2007-08-13 22:52                                   ` Christoph Lameter
2007-08-13 23:55                                     ` Andi Kleen
2007-08-13 23:12                                       ` Christoph Lameter
2007-08-14  0:16                                         ` Andi Kleen
2007-08-13 23:25                                           ` Christoph Lameter
2007-08-14  0:25                                             ` Andi Kleen
2007-08-13 22:38                               ` Christoph Lameter
2007-08-13 23:43                                 ` Andi Kleen
2007-08-13 22:54                                   ` Christoph Lameter
2007-08-14  0:00                                     ` Andi Kleen
2007-08-13 23:16                                       ` Christoph Lameter
2007-08-14  0:16                                         ` Andi Kleen
2007-08-13 23:27                                           ` Christoph Lameter
2007-08-14  0:26                                             ` Andi Kleen
2007-08-14 19:56                                               ` Christoph Lameter
2007-08-13 23:22                                       ` Alan Cox
2007-08-14  0:14                                         ` Andi Kleen
2007-08-13 23:44                                           ` Alan Cox
2007-08-14 19:11                                           ` Andy Isaacson
2007-08-14 20:23                                             ` Andi Kleen
2007-08-14 19:43                                               ` Andy Isaacson
2007-08-14 21:05                                                 ` Andi Kleen
2007-08-15 11:37                                           ` Ralf Baechle
2007-08-15 12:59                                             ` Andi Kleen
2007-08-15 12:32                                               ` Ralf Baechle
2007-08-15 19:59                                               ` Christoph Lameter
2007-08-09 21:07 ` Mel Gorman [this message]
2007-08-09 21:37   ` [PATCH 4/4] Apply MPOL_BIND policy to two highest zones when highest is ZONE_MOVABLE Christoph Lameter
2007-08-09 21:19 ` [PATCH 0/4] Use one zonelist per node instead of multiple zonelists v3 Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070809210736.14702.36541.sendpatchset@skynet.skynet.ie \
    --to=mel@csn.ul.ie \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=ak@suse.de \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox