From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 6 Aug 2007 12:44:08 -0700 From: Andrew Morton Subject: Re: [PATCH] Apply memory policies to top two highest zones when highest zone is ZONE_MOVABLE Message-Id: <20070806124408.16034ab8.akpm@linux-foundation.org> In-Reply-To: References: <20070802172118.GD23133@skynet.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Mel Gorman , pj@sgi.com, Lee.Schermerhorn@hp.com, kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Paul Mundt List-ID: On Thu, 2 Aug 2007 13:45:23 -0700 (PDT) Christoph Lameter wrote: > On Thu, 2 Aug 2007, Mel Gorman wrote: > > > +#ifdef CONFIG_NUMA > > +/* > > + * Only custom zonelists like MPOL_BIND need to be filtered as part of > > + * policies. As described in the comment for struct zonelist_cache, these > > + * zonelists will not have a zlcache so zlcache_ptr will not be set. Use > > + * that to determine if the zonelists needs to be filtered or not. > > + */ > > +static inline int alloc_should_filter_zonelist(struct zonelist *zonelist) > > +{ > > + return !zonelist->zlcache_ptr; > > +} > > I guess Paul needs to have a look at this one. Which Paul? > Otherwise > > Acked-by: Christoph Lameter > > > @@ -1166,6 +1167,18 @@ zonelist_scan: > > z = zonelist->zones; > > > > do { > > + /* > > + * In NUMA, this could be a policy zonelist which contains > > + * zones that may not be allowed by the current gfp_mask. > > + * Check the zone is allowed by the current flags > > + */ > > + if (unlikely(alloc_should_filter_zonelist(zonelist))) { > > + if (highest_zoneidx == -1) > > + highest_zoneidx = gfp_zone(gfp_mask); > > + if (zone_idx(*z) > highest_zoneidx) > > + continue; > > + } > > + > > if (NUMA_BUILD && zlc_active && > > Hotpath. Sigh. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org