From: Andrew Morton <akpm@linux-foundation.org>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Mel Gorman <mel@csn.ul.ie>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] wait for page writeback when directly reclaiming contiguous areas
Date: Mon, 6 Aug 2007 12:22:04 -0700 [thread overview]
Message-ID: <20070806122204.924fa0e9.akpm@linux-foundation.org> (raw)
In-Reply-To: <7bdbf266c3f68dc57a9cf7469c2652a5@pinky>
On Thu, 02 Aug 2007 19:18:43 +0100 Andy Whitcroft <apw@shadowen.org> wrote:
> @@ -458,8 +475,15 @@ static unsigned long shrink_page_list(struct list_head *page_list,
> if (page_mapped(page) || PageSwapCache(page))
> sc->nr_scanned++;
>
> - if (PageWriteback(page))
> - goto keep_locked;
> + may_enter_fs = (sc->gfp_mask & __GFP_FS) ||
> + (PageSwapCache(page) && (sc->gfp_mask & __GFP_IO));
> +
> + if (PageWriteback(page)) {
> + if (sync_writeback == PAGEOUT_IO_SYNC && may_enter_fs)
> + wait_on_page_writeback(page);
> + else
> + goto keep_locked;
> + }
this bit could do with a comment explaining the design decisions, please.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-08-06 19:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-02 18:17 [PATCH 0/2] Synchronous Lumpy Reclaim V3 Andy Whitcroft
2007-08-02 18:18 ` [PATCH 1/2] ensure we count pages transitioning inactive via clear_active_flags Andy Whitcroft
2007-08-02 18:18 ` [PATCH 2/2] wait for page writeback when directly reclaiming contiguous areas Andy Whitcroft
2007-08-06 19:22 ` Andrew Morton [this message]
2007-08-07 15:31 ` [PATCH] synchronous lumpy: improve commentary on writeback wait Andy Whitcroft
2007-08-02 18:35 ` [PATCH 0/2] Synchronous Lumpy Reclaim V3 Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2007-07-28 22:51 [PATCH 0/2] Synchronous Lumpy Reclaim V2 Andy Whitcroft
2007-07-28 22:52 ` [PATCH 2/2] Wait for page writeback when directly reclaiming contiguous areas Andy Whitcroft
2007-07-30 20:49 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070806122204.924fa0e9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox