From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sun, 5 Aug 2007 21:04:46 +0100 From: Alan Cox Subject: Re: [patch] implement smarter atime updates support Message-ID: <20070805210446.57aa66f6@the-village.bc.nu> In-Reply-To: <1186343582.25667.3.camel@laptopd505.fenrus.org> References: <20070804163733.GA31001@elte.hu> <46B4C0A8.1000902@garzik.org> <20070805102021.GA4246@unthought.net> <46B5A996.5060006@garzik.org> <20070805105850.GC4246@unthought.net> <20070805124648.GA21173@elte.hu> <20070805190928.GA17433@elte.hu> <20070805192226.GA20234@elte.hu> <1186343582.25667.3.camel@laptopd505.fenrus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Arjan van de Ven Cc: Ingo Molnar , Linus Torvalds , Jakob Oestergaard , Jeff Garzik , miklos@szeredi.hu, akpm@linux-foundation.org, neilb@suse.de, dgc@sgi.com, tomoki.sekiyama.qu@hitachi.com, Peter Zijlstra , linux-mm@kvack.org, Linux Kernel Mailing List , nikita@clusterfs.com, trond.myklebust@fys.uio.no, yingchao.zhou@gmail.com, richard@rsk.demon.co.uk, david@lang.hm List-ID: O> you might want to add > > /* > * if the inode is dirty already, do the atime update since > * we'll be doing the disk IO anyway to clean the inode. > */ > if (inode->i_state & I_DIRTY) > return 1; This makes the actual result somewhat less predictable. Is that wise ? Right now its clear what happens based on what user sequence of events and that this is easily repeatable. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org