linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
From: Mark Fortescue <mark@mtfhpc.demon.co.uk>
To: mark@mtfhpc.demon.co.uk
Cc: aaw@google.com, akpm@linux-foundation.org,
	linux-arch@vger.kernel.org, sparclinux@vger.kernel.org,
	wli@holomorphy.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [SPARC32] NULL pointer derefference
Date: Mon, 30 Jul 2007 23:42:52 -0700 (PDT)	[thread overview]
Date: Tue, 31 Jul 2007 06:35:29 +0100 (BST)	[thread overview]
Message-ID: <20070730.234252.74747206.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.61.0707310557470.3926@mtfhpc.demon.co.uk>

> The original code did a job lot of pte stuf in install_arg_page. The
> new code seems to replace this using get_user_pages but I have not
> worked out how get_user_pages gets to the point at which it
> allocated pte's i.e.  maps the stack memory it is about to put the
> arguments into.

get_user_pages() essentially walks through the requested user address
space, faults in pages if necessary, and returns references to those
pages.

The logic of get_user_pages() you need to be concerned about is
this inner loop:

			while (!(page = follow_page(vma, start, foll_flags))) {
				int ret;
				ret = handle_mm_fault(mm, vma, start,
						foll_flags & FOLL_WRITE);
 ...
			}

handle_mm_fault() does all the dirty work of a page fault, and
is how we get to update_mmu_cache(), the sun4c implementation of
which is where you see the crash.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-07-31  6:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-30  2:18 Mark Fortescue
2007-07-30  4:19 ` David Miller, Mark Fortescue
2007-07-30 10:39   ` Mark Fortescue
2007-07-31  5:35   ` Mark Fortescue
2007-07-31  6:42     ` David Miller, Mark Fortescue [this message]
2007-07-31  7:55       ` [PATCH] " Mark Fortescue
2007-07-31  9:02         ` David Miller, Mark Fortescue
2007-07-31  5:10 ` Ollie Wild
2007-07-31  6:54   ` Mark Fortescue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070730.234252.74747206.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=aaw@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mark@mtfhpc.demon.co.uk \
    --cc=sparclinux@vger.kernel.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox