From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-mm@kvack.org, Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: Slab API: Remove useless ctor parameter and reorder parameters
Date: Tue, 24 Jul 2007 17:53:32 -0700 [thread overview]
Message-ID: <20070724175332.41ade708.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0707241705380.9633@schroedinger.engr.sgi.com>
On Tue, 24 Jul 2007 17:35:53 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote:
> On Tue, 24 Jul 2007, Andrew Morton wrote:
>
> > arch/i386/mm/pgtable.c:197: error: conflicting types for 'pmd_ctor'
> > include/asm/pgtable.h:43: error: previous declaration of 'pmd_ctor' was here
>
> Ahh. External declaration of pmd_ctor missed in .h. Patch follows.
<regards it in terror>
> > Now is the 100% worst time to merge this sort of thing btw: I get to carry
> > it for two months while the world churns. Around the -rc7 timeframe would
> > be better.
>
> We just got rid of the destructor parameter of kmem_cache_create.
Yeah, but that got merged into mainline. It's too late to merge this one.
> It would
> be consistent to also get rid of the useless flag in the ctor at the
> same time.
Honest, it's easier for everyone if we shelve this until late -rc's.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-07-25 0:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 5:48 Christoph Lameter
2007-07-24 7:26 ` Christoph Lameter
2007-07-24 23:59 ` Andrew Morton
2007-07-25 0:35 ` Christoph Lameter
2007-07-25 0:53 ` Andrew Morton [this message]
2007-07-25 3:15 ` Christoph Lameter
2007-07-25 10:33 ` Pekka Enberg
2007-07-25 18:56 ` Christoph Lameter
2007-09-14 22:17 Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070724175332.41ade708.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox