From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 24 Jul 2007 16:12:47 -0700 From: Andrew Morton Subject: Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK Message-Id: <20070724161247.ee1a2546.akpm@linux-foundation.org> In-Reply-To: References: <1185185020.8197.11.camel@twins> <20070723112143.GB19437@skynet.ie> <1185190711.8197.15.camel@twins> <1185256869.8197.27.camel@twins> <1185261894.8197.33.camel@twins> <20070724120751.401bcbcb@schroedinger.engr.sgi.com> <20070724122542.d4ac734a.akpm@linux-foundation.org> <20070724151046.d8fbb7da.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Peter Zijlstra , Mel Gorman , Linus Torvalds , linux-kernel , Daniel Phillips , linux-mm List-ID: On Tue, 24 Jul 2007 16:00:32 -0700 (PDT) Christoph Lameter wrote: > On Tue, 24 Jul 2007, Andrew Morton wrote: > > > I think I'll duck this for now. Otherwise I have a suspicion that I'll > > be the first person to run it and I'm too old for such excitement. > > I always had the suspicion that you have some magical script > which will immediately tell you that a patch is not working ;-) sort of a defensive crouch. > Works fine on x86_64 (on top of the ctor cleanup patchset) and passes the > kernel build test but then there may be creatively designed drivers and > such that pass these flags to the slab allocators which will now BUG. __GFP_COLD looks OK. __GFP_COMP I'm not so sure about. drivers/char/drm/drm_pci.c:drm_pci_alloc() (and other places like infiniband) pass it into dma_alloc_coherent() which some architectures implement via slab. umm, arch/arm/mm/consistent.c is one such. __GFP_MOVABLE looks OK. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org