From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 23 Jul 2007 12:36:18 -0700 From: Christoph Lameter Subject: Re: [PATCH 3/7] Generic Virtual Memmap support for SPARSEMEM Message-ID: <20070723123618.4a25f902@schroedinger.engr.sgi.com> In-Reply-To: <20070714163319.GA14184@infradead.org> References: <20070714152058.GA12478@infradead.org> <20070714163319.GA14184@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Hellwig Cc: Andy Whitcroft , linux-mm@kvack.org, linux-arch@vger.kernel.org, Nick Piggin , Mel Gorman List-ID: On Sat, 14 Jul 2007 17:33:19 +0100 Christoph Hellwig wrote: > It's not generic. Most of it is under a maze of obscure config > options. The patchset in it's current form is a complete mess of > obscure ifefery and not quite generic code. And it only adds new > memory models without ripping old stuff out. So while I really like > the basic idea the patches need quite a lot more work until they're > mergeable. It is generic. If you would put the components into each arch then you would needlessly duplicate code. In order to rip stuff out we first need to have sparsemem contain all the features of discontig. Then we can start to get rid of discontig and then we will be able to reduce the number of memory models supported by sparsemem. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org