From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e2.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id l6KM7jlR022744 for ; Fri, 20 Jul 2007 18:07:45 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v8.4) with ESMTP id l6KM7j3n508078 for ; Fri, 20 Jul 2007 18:07:45 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l6KM7j5c027155 for ; Fri, 20 Jul 2007 18:07:45 -0400 Date: Fri, 20 Jul 2007 15:07:44 -0700 From: Nishanth Aravamudan Subject: Re: [PATCH] Memoryless nodes: use "node_memory_map" for cpuset mems_allowed validation Message-ID: <20070720220744.GH2083@us.ibm.com> References: <20070711182219.234782227@sgi.com> <20070711182250.005856256@sgi.com> <1184964564.9651.66.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1184964564.9651.66.camel@localhost> Sender: owner-linux-mm@kvack.org Return-Path: To: Lee Schermerhorn Cc: Christoph Lameter , Paul Jackson , akpm@linux-foundation.org, kxr@sgi.com, linux-mm@kvack.org, KAMEZAWA Hiroyuki List-ID: On 20.07.2007 [16:49:24 -0400], Lee Schermerhorn wrote: > This fixes a problem I encountered testing Christoph's memoryless nodes > series. Applies atop that series. Other than this, series holds up > under what testing I've been able to do this week. > > Memoryless Nodes: use "node_memory_map" for cpusets mems_allowed validation > > cpusets try to ensure that any node added to a cpuset's > mems_allowed is on-line and contains memory. The assumption > was that online nodes contained memory. Thus, it is possible > to add memoryless nodes to a cpuset and then add tasks to this > cpuset. This results in continuous series of oom-kill and other > console stack traces and apparent system hang. > > Change cpusets to use node_states[N_MEMORY] [a.k.a. > node_memory_map] in place of node_online_map when vetting > memories. Return error if admin attempts to write a non-empty > mems_allowed node mask containing only memoryless-nodes. Yep, in cursorily looking at the hugetlb pool growing with cpusets (more specifically at cpuset.c), I was thinking this would be necessary. > Signed-off-by: Lee Schermerhorn Acked-by: Nishanth Aravamudan Thanks, Nish -- Nishanth Aravamudan IBM Linux Technology Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org