linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Chinner <dgc@sgi.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Fengguang Wu <fengguang.wu@gmail.com>,
	Ken Chen <kenchen@google.com>,
	linux-mm@kvack.org
Subject: Re: [patch] fix periodic superblock dirty inode flushing
Date: Fri, 20 Jul 2007 08:18:05 +1000	[thread overview]
Message-ID: <20070719221805.GY31489@sgi.com> (raw)
In-Reply-To: <20070719011845.3e747a56.akpm@linux-foundation.org>

On Thu, Jul 19, 2007 at 01:18:45AM -0700, Andrew Morton wrote:
> On Thu, 19 Jul 2007 16:09:10 +0800 Fengguang Wu <fengguang.wu@gmail.com> wrote:
> > On Wed, Jul 18, 2007 at 08:10:18PM -0700, Andrew Morton wrote:
> > > With an indexed data structure (ie: radix-tree or rbtree) the writeback
> > > code can remember where it was up to in the ordered list of inodes so it
> > > can drop locks, do writeback, remember where it was up to for the next
> > > pass, etc.
> > > 
> > > Basically, the walk of the per-superblock inodes would follow the same
> > > model as the walk of the per-inode pages.  And the latter has worked out
> > > *really* well.  It would be great if the per-sb inode traversal was as
> > > flexible and as powerful as the page walks.
> > > 
> > > Probably it never will be, because I suspect we'd need to order the inodes
> > > by multiple indices.  I hn't thought it through, really.  
> > 
> > Just one more possibility...  an array of lists?
> > 
> > The array is cyclic and time-addressable, and
> > the lists can be ordered by other criterion(s).
> 
> Yeah, something like that.
> 
> The array would need to be dynamically sizeable and capable of
> efficiently supporting large holes.  ie: a radix-tree or rbtree ;)

You mean sorta like fs/xfs/xfs_mru_cache.[ch]?

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2007-07-19 22:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-12  4:21 Ken Chen
2007-07-12 19:05 ` Andrew Morton
2007-07-13 22:17   ` Ken Chen
2007-07-17  0:01     ` Ken Chen
2007-07-17  0:15       ` Andrew Morton
     [not found]       ` <20070719025927.GA11874@mail.ustc.edu.cn>
2007-07-19  2:59         ` Fengguang Wu
2007-07-19  3:10           ` Andrew Morton
     [not found]             ` <20070719080910.GA7459@mail.ustc.edu.cn>
2007-07-19  8:09               ` Fengguang Wu
2007-07-19  8:18                 ` Andrew Morton
2007-07-19 22:18                   ` David Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070719221805.GY31489@sgi.com \
    --to=dgc@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@gmail.com \
    --cc=kenchen@google.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox