Re: [patch 11/12] Memoryless nodes: Fix GFP_THISNODE behavior

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

some nitpicks...

On Tue, 10 Jul 2007 14:52:16 -0700
Christoph Lameter <clameter@sgi.com> wrote:

> +static void build_thisnode_zonelists(pg_data_t *pgdat)
> +{
> +	enum zone_type i;
> +	int j;
> +	struct zonelist *zonelist;
> +
> +	for (i = 0; i < MAX_NR_ZONES; i++) {
> +		zonelist = pgdat->node_zonelists + MAX_NR_ZONES + i;
> + 		j = build_zonelists_node(pgdat, zonelist, 0, i);
> +		zonelist->zones[j] = NULL;
> +	}
> +}
adding explanation as following is maybe good.
==
	/* 
         * NUMA default zonelist is structured as
	 * [0....MAX_NR_ZONES) : allows fallbacks to other node for each GFP_MASK.
	 * [MAX_NR_ZONES...MAX_ZONELISTS) : disallow fallbacks for GFP_XXX |GFP_THISNODE
	 */
==
> +
> +/*
>   * Build zonelists ordered by zone and nodes within zones.
>   * This results in conserving DMA zone[s] until all Normal memory is
>   * exhausted, but results in overflowing to remote node while memory
> @@ -2267,7 +2283,7 @@ static void build_zonelists(pg_data_t *p
>  	int order = current_zonelist_order;
>  
>  	/* initialize zonelists */
> -	for (i = 0; i < MAX_NR_ZONES; i++) {
> +	for (i = 0; i < 2 * MAX_NR_ZONES; i++) {

please use MAX_ZONELISTS here.

-Kame

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>