From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 6 Jul 2007 18:50:06 +0900 From: KAMEZAWA Hiroyuki Subject: Re: [BUGFIX]{PATCH] flush icache on ia64 take2 Message-Id: <20070706185006.0014bea5.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <468E0E52.2060705@bull.net> References: <20070706112901.16bb5f8a.kamezawa.hiroyu@jp.fujitsu.com> <468E0E52.2060705@bull.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Zoltan Menyhart Cc: linux-ia64@vger.kernel.org, LKML , linux-mm@kvack.org, "tony.luck@intel.com" , nickpiggin@yahoo.com.au, mike@stroyan.net, dmosberger@gmail.com, GOTO List-ID: On Fri, 06 Jul 2007 11:41:38 +0200 Zoltan Menyhart wrote: > KAMEZAWA Hiroyuki wrote: > > > Note1: icache flush is called only when VM_EXEC flag is on and > > PG_arch_1 is not set. > > If you have not got the page in the cache, then the new page will > be allocated with PG_arch_1 bit off. > You are going to flush pages which are read by HW DMA, i.e. the L2I > of Montecito does not keep old lines for those pages anyway. > yes, it's my concern. > ...->a_ops->readpage() of "L2I safe" file systems should set PG_arch_1 > if the CPU is ia64 and it has got separate L2I. > > On the other hand, arch. independent file systems should not play with > PG_arch_1. > The base kernel should export a macro for the file systems... > Hm, but it should be discussed in another thread... I think. >>From memory management view, flush_icache before set_pte() is sane thing. -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org