Re: [PATCH 1/7] KAMEZAWA Hiroyuki hot-remove patches

[mel@skynet.ie (Mel Gorman)]

On (18/06/07 09:56), Christoph Lameter didst pronounce:
> On Mon, 18 Jun 2007, Mel Gorman wrote:
> 
> > @@ -632,18 +632,27 @@ static int unmap_and_move(new_page_t get
> >  			goto unlock;
> >  		wait_on_page_writeback(page);
> >  	}
> > -
> > +	/* anon_vma should not be freed while migration. */
> > +	if (PageAnon(page)) {
> > +		rcu_read_lock();
> > +		rcu_locked = 1;
> > +	}
> 
> We agreed on doing rcu_read_lock removing the status variable 
> and checking for PageAnon(). Doing so deuglifies the 
> function.

It makes it less ugly but when making the retry-logic for migration better I
was also routinely locking up my test-box hard. I intend to run this inside
a simulator so I can use gdb to figure out what is going wrong but for the
moment I've actually gone back to using a slightly modified anon_vma patch.

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>