From: Andi Kleen <ak@suse.de>
To: Arnout Engelen <arnouten@bzzt.net>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] More informative logging for OOM-killer
Date: Fri, 15 Jun 2007 13:35:16 +0200 [thread overview]
Message-ID: <200706151335.16607.ak@suse.de> (raw)
In-Reply-To: <4671B1CA.8070908@bzzt.net>
On Thursday 14 June 2007 23:23:22 Arnout Engelen wrote:
> + // TODO is this a proper upper bound for the
> + // length of a commandline?
> + char buffer[PAGE_SIZE / sizeof(char)];
That's a 100% guaranteed stack overflow with 4K stacks.
And sizeof(char) is always 1 btw.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2007-06-15 11:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-14 21:23 Arnout Engelen
2007-06-15 11:35 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706151335.16607.ak@suse.de \
--to=ak@suse.de \
--cc=arnouten@bzzt.net \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox