From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e2.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id l5C2dND5015755 for ; Mon, 11 Jun 2007 22:39:23 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5C2dNFY558522 for ; Mon, 11 Jun 2007 22:39:23 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5C2dNj8013891 for ; Mon, 11 Jun 2007 22:39:23 -0400 Date: Mon, 11 Jun 2007 19:39:21 -0700 From: Nishanth Aravamudan Subject: Re: [PATCH] populated_map: fix !NUMA case, remove comment Message-ID: <20070612023921.GN3798@us.ibm.com> References: <20070611221036.GA14458@us.ibm.com> <20070611225213.GB14458@us.ibm.com> <20070611234155.GG14458@us.ibm.com> <20070612000705.GH14458@us.ibm.com> <20070612014357.GD3798@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: lee.schermerhorn@hp.com, anton@samba.org, akpm@linux-foundation.org, linux-mm@kvack.org List-ID: On 11.06.2007 [18:45:55 -0700], Christoph Lameter wrote: > On Mon, 11 Jun 2007, Nishanth Aravamudan wrote: > > > Ah, but we'll use it in mpol_new via nodes_and() regardless of > > NUMA/!NUMA, right? > > mempolicy.c will only be compiled for the NUMA case. > > > If you really feel that only CONFIG_NUMA code should use > > node_populated_mask, then I'll make that change and use > > node_populated() in the callers. > > What point would there be of !NUMA configurations using > node_populated_mask()? I really don't get this inconsistency...why do we export node_online_map and node_possible_map in !NUMA configurations, then? Note, node_online_mask is used currently in hugetlb.c to achieve "interleaving" of fresh hugepages. And has no dependency on NUMA to be compiled or not. Thanks, Nish -- Nishanth Aravamudan IBM Linux Technology Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org