Re: [PATCH][RFC] hugetlb: add per-node nr_hugepages sysfs attribute

[Nishanth Aravamudan <nacc@us.ibm.com>]

On 11.06.2007 [16:42:33 -0700], Christoph Lameter wrote:
> On Mon, 11 Jun 2007, Nishanth Aravamudan wrote:
> 
> >  }
> >  static SYSDEV_ATTR(distance, S_IRUGO, node_read_distance, NULL);
> >  
> > +#ifdef CONFIG_HUGETLB_PAGE
> > +static SYSDEV_ATTR(nr_hugepages, S_IRUGO | S_IWUSR,
> > +				hugetlb_read_nr_hugepages_node,
> > +				hugetlb_write_nr_hugepages_node);
> > +#endif
> 
> Move the above to hugetlb.c?
> 
> Also so far there is nothing in the nodes directories that can be 
> modified. This is the first one. Is that really the right location?

I will rework this taking into account this comment and the other
(sorry, forgot to refresh the patch and the commentary after the other
changes).

As far as moving it, that might be the best option, but I'm not sure how
to make sure that everything builds. Will ponder.

Also, I don't really see where else a per-node attribute should go other
than /sys/devices/system/node/nodeX... Did you have a better location in
mind?

Thanks,
Nish

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>