From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sat, 9 Jun 2007 16:38:52 +0200 From: Andrea Arcangeli Subject: Re: [PATCH 10 of 16] stop useless vm trashing while we wait the TIF_MEMDIE task to exit Message-ID: <20070609143852.GB7130@v2.random> References: <24250f0be1aa26e5c6e3.1181332988@v2.random> <20070609015944.GL9380@v2.random> <20070609140552.GA7130@v2.random> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070609140552.GA7130@v2.random> Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: linux-mm@kvack.org List-ID: On a side note about the current way you select the task to kill if a constrained alloc failure triggers, I think it would have been better if you simply extended the oom-selector by filtering tasks in function of the current->mems_allowed. Now I agree the current badness is quite bad, now with rss instead of the virtual space, it works a bit better at least, but the whole point is that if you integrate the cpuset task filtering in the oom-selector algorithm, then once we fix the badness algorithm to actually do something more meaningful than to check static values, you'll get the better algorithm working for your local-oom killing too. This if you really care about the huge-numa niche to get node-partitioning working really like if this was a virtualized environment. If you just have kill something to release memory, killing the current task is always the safest choice obviously, so as your customers are ok with it I'm certainly fine with the current approach too. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org