From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 8 Jun 2007 16:01:48 +0900 From: KAMEZAWA Hiroyuki Subject: Re: memory unplug v4 intro [1/6] migration without mm->sem Message-Id: <20070608160148.616dae54.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: References: <20070608143531.411c76df.kamezawa.hiroyu@jp.fujitsu.com> <20070608143844.569c2804.kamezawa.hiroyu@jp.fujitsu.com> <20070608145435.4fa7c9b6.kamezawa.hiroyu@jp.fujitsu.com> <20070608150602.78f07b34.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: linux-mm@kvack.org, mel@csn.ul.ie, y-goto@jp.fujitsu.com, hugh@veritas.com List-ID: On Thu, 7 Jun 2007 23:44:38 -0700 (PDT) Christoph Lameter wrote: > I think what Hugh meant is someething like this: > Hmm, I see. > /* > + * Add dummy vma so that the vma cannot vanish under us > + */ > + if (PageAnon(page)) > + anon_vma_link(&dummy_vma); > + Before calling anon_vma_link(), I have to set "dummy_vma->anon_vma = anon_vma". anon_vma_hold() does what it has to do. But it's not necessary to add anon_vma_hold() in rmap.c, as you pointed out. I'll rewrite them as static func in migrate.c -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org