Re: [PATCH v2] gfp.h: GFP_THISNODE can go to other nodes if some are unpopulated

[Nishanth Aravamudan <nacc@us.ibm.com>]

On 07.06.2007 [15:05:56 -0700], Christoph Lameter wrote:
> On Thu, 7 Jun 2007, Nishanth Aravamudan wrote:
> 
> >  /*
> > - * NOTE: if the requested node is unpopulated (no memory), a THISNODE
> > - * request can go to other nodes due to the fallback list
> > + * NOTE: GFP_THISNODE allocates from the first available pgdat (== node
> > + * structure) from the zonelist of the requested node. The first pgdat
> > + * may be the pgdat of another node if the requested node has no memory
> > + * on its own.
> >   */
> >  #define GFP_THISNODE	(__GFP_THISNODE | __GFP_NOWARN | __GFP_NORETRY)
> >  #else
> 
> Acked-by: Christoph Lameter <clameter@sgi.com>

Thanks, I'm an idiot, though, and didn't reset to stock -linus before
refreshing my patch:

gfp.h: GFP_THISNODE can go to other nodes if some are unpopulated

While testing my sysfs per-node hugepage allocator
(http://marc.info/?l=linux-mm&m=117935849517122&w=2), I found that an
alloc_pages_node(nid, GFP_THISNODE) request would sometimes return a
struct page such that page_to_nid(page) != nid. This was because, on
that particular machine, nodes 0 and 1 are populated and nodes 2 and 3
are not. When a page is requested get_page_from_freelist() relies on
zonelist->zones[0]->zone_pgdat indicating when THISNODE stops. But,
because, say, node 2 has no memory, the first zone_pgdat in the fallback
list points to a different node. Add a comment indicating that THISNODE
may not return pages on THISNODE if the node is unpopulated.

Am working on testing Lee/Anton's patch to add a node_populated_mask and
use that in the hugepage allocator path. But I think this may be a
problem anywhere THISNODE is used and memory is expected to come from
the requested node and nowhere else.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Acked-by: Christoph Lameter <clameter@sgi.com>

diff --git a/include/linux/gfp.h b/include/linux/gfp.h
index 0d2ef0b..996cf08 100644
--- a/include/linux/gfp.h
+++ b/include/linux/gfp.h
@@ -67,6 +67,12 @@ struct vm_area_struct;
 			 __GFP_HIGHMEM)
 
 #ifdef CONFIG_NUMA
+/*
+ * NOTE: GFP_THISNODE allocates from the first available pgdat (== node
+ * structure) from the zonelist of the requested node. The first pgdat
+ * may be the pgdat of another node if the requested node has no memory
+ * on its own.
+ */
 #define GFP_THISNODE	(__GFP_THISNODE | __GFP_NOWARN | __GFP_NORETRY)
 #else
 #define GFP_THISNODE	((__force gfp_t)0)

-- 
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>