From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 6 Jun 2007 13:34:32 -0700 From: Andrew Morton Subject: Re: SLUB: Use ilog2 instead of series of constant comparisons. Message-Id: <20070606133432.2f3cb26a.akpm@linux-foundation.org> In-Reply-To: References: <20070606100817.7af24b74.akpm@linux-foundation.org> <20070606131121.a8f7be78.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: linux-mm@kvack.org, Pekka Enberg , Andy Whitcroft , Martin Bligh List-ID: On Wed, 6 Jun 2007 13:28:40 -0700 (PDT) Christoph Lameter wrote: > On Wed, 6 Jun 2007, Andrew Morton wrote: > > > > There is also nothing special in CalcNTLMv2_partial_mac_key(). Two > > > kmallocs of 33 bytes and 132 bytes each. > > > > Yes, the code all looks OK. I suspect this is another case of the compiler > > failing to remove unreachable stuff. > > Sigh. > > The patch was already in 2.6.22-rc3-mm1. Why did the patch pass the > testing during that release cycle? Good question - don't know, sorry. I tried to build gcc-3.3.3 the other day. Would you believe that gcc-4.1.0 fails to compile gcc-3.3.3? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org