linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-mm@kvack.org, Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: SLUB: Use ilog2 instead of series of constant comparisons.
Date: Wed, 6 Jun 2007 10:08:17 -0700	[thread overview]
Message-ID: <20070606100817.7af24b74.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0705211250410.27950@schroedinger.engr.sgi.com>

On Mon, 21 May 2007 12:51:47 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote:

> I finally found a way to get rid of the nasty list of comparisions in
> slub_def.h. ilog2 seems to work right for constants.

This caused test.kernel.org's power4 build to blow up:

http://test.kernel.org/abat/93315/debug/test.log.0

fs/built-in.o(.text+0x148420): In function `.CalcNTLMv2_partial_mac_key':
: undefined reference to `.____ilog2_NaN'

it doesn't happen on my power4 toolchain so I expect it's some artifact
due to test.k.o's tendency to use crufty old toolchains.

arguably it's a bug in ilog2, dunno.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2007-06-06 17:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-21 19:51 Christoph Lameter
2007-05-22  8:45 ` Pekka Enberg
2007-06-06 17:08 ` Andrew Morton [this message]
2007-06-06 18:36   ` Christoph Lameter
2007-06-06 20:11     ` Andrew Morton
2007-06-06 20:28       ` Christoph Lameter
2007-06-06 20:34         ` Andrew Morton
2007-06-06 20:41           ` Martin Bligh
2007-06-06 20:52             ` Christoph Lameter
2007-06-06 23:19               ` Andrew Morton
2007-06-06 23:50                 ` Christoph Lameter
2007-06-07  0:01                   ` Nish Aravamudan
2007-06-07  3:49                     ` Christoph Lameter
2007-06-06 23:31             ` Nish Aravamudan
2007-06-07  7:40             ` Andy Whitcroft
2007-06-06 20:43           ` Christoph Lameter
2007-06-06 20:29       ` Nish Aravamudan
2007-06-07  7:48         ` Andy Whitcroft
2007-06-07  7:58           ` Andy Whitcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070606100817.7af24b74.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=linux-mm@kvack.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox