linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: clameter@sgi.com
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, akpm@linux-foundation.org
Subject: [RFC 2/4] CONFIG_STABLE: Switch off kmalloc(0) tests in slab allocators
Date: Wed, 30 May 2007 17:20:49 -0700	[thread overview]
Message-ID: <20070531003012.532539202@sgi.com> (raw)
In-Reply-To: <20070531002047.702473071@sgi.com>

[-- Attachment #1: stable_kmalloc_zero --]
[-- Type: text/plain, Size: 1674 bytes --]

We do not want kmalloc(0) to trigger stackdumps if this is a stable
kernel. kmalloc(0) is currently harmless.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

---
 include/linux/slub_def.h |    2 ++
 mm/slab.c                |    2 ++
 2 files changed, 4 insertions(+)

Index: slub/include/linux/slub_def.h
===================================================================
--- slub.orig/include/linux/slub_def.h	2007-05-30 16:35:05.000000000 -0700
+++ slub/include/linux/slub_def.h	2007-05-30 16:37:39.000000000 -0700
@@ -74,6 +74,7 @@ extern struct kmem_cache kmalloc_caches[
  */
 static inline int kmalloc_index(size_t size)
 {
+#ifndef CONFIG_STABLE
 	/*
 	 * We should return 0 if size == 0 (which would result in the
 	 * kmalloc caller to get NULL) but we use the smallest object
@@ -81,6 +82,7 @@ static inline int kmalloc_index(size_t s
 	 * we can discover locations where we do 0 sized allocations.
 	 */
 	WARN_ON_ONCE(size == 0);
+#endif
 
 	if (size > KMALLOC_MAX_SIZE)
 		return -1;
Index: slub/mm/slab.c
===================================================================
--- slub.orig/mm/slab.c	2007-05-30 16:35:05.000000000 -0700
+++ slub/mm/slab.c	2007-05-30 16:37:39.000000000 -0700
@@ -774,7 +774,9 @@ static inline struct kmem_cache *__find_
 	 */
 	BUG_ON(malloc_sizes[INDEX_AC].cs_cachep == NULL);
 #endif
+#ifndef CONFIG_STABLE
 	WARN_ON_ONCE(size == 0);
+#endif
 	while (size > csizep->cs_size)
 		csizep++;
 

-- 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2007-05-31  0:20 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-31  0:20 [RFC 0/4] CONFIG_STABLE to switch off development checks clameter
2007-05-31  0:20 ` [RFC 1/4] CONFIG_STABLE: Define it clameter
2007-05-31  0:35   ` young dave
2007-05-31  0:49     ` Christoph Lameter
2007-06-01 18:08       ` Dave Jones
2007-06-01 18:25         ` Christoph Lameter
2007-05-31  8:54   ` Stefan Richter
2007-05-31  9:03     ` David Miller, Stefan Richter
2007-05-31  9:03     ` Stefan Richter
2007-05-31 21:11   ` Andrew Morton
2007-05-31 21:14     ` Christoph Lameter
2007-05-31 21:30     ` Sam Ravnborg
2007-06-01 18:02       ` Dave Jones
2007-06-01 20:22         ` Sam Ravnborg
2007-06-01 20:30           ` Dave Jones
2007-06-01 20:55             ` Sam Ravnborg
2007-06-01 20:25     ` Sam Ravnborg
2007-07-20 10:41   ` Satyam Sharma
2007-07-20 11:09     ` Chris Snook
2007-07-20 11:27       ` Satyam Sharma
2007-07-20 11:34         ` Chris Snook
2007-07-20 11:40           ` Satyam Sharma
2007-07-20 11:50             ` Chris Snook
2007-07-20 16:48               ` Stefan Richter
2007-07-20 16:28     ` Stefan Richter
2007-07-20 16:36       ` Stefan Richter
2007-07-20 19:09         ` Chuck Ebbert
2007-05-31  0:20 ` clameter [this message]
2007-05-31 19:51   ` [RFC 2/4] CONFIG_STABLE: Switch off kmalloc(0) tests in slab allocators Zach Brown
2007-05-31 22:37     ` Andi Kleen
2007-05-31  0:20 ` [RFC 3/4] CONFIG_STABLE: Switch off SLUB banner clameter
2007-05-31  0:20 ` [RFC 4/4] CONFIG_STABLE: SLUB: Prefer object corruption over failure clameter
2007-06-01 14:55 ` [RFC 0/4] CONFIG_STABLE to switch off development checks Jeremy Fitzhardinge
2007-06-01 18:38   ` Christoph Lameter
2007-06-01 18:58     ` Jeremy Fitzhardinge
2007-06-01 20:59       ` Christoph Lameter
2007-06-01 21:24         ` Jeremy Fitzhardinge
2007-06-02 15:23       ` Dave Kleikamp
2007-06-02 16:28         ` Jeremy Fitzhardinge
2007-06-04  1:03           ` Dave Kleikamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070531003012.532539202@sgi.com \
    --to=clameter@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox