linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: clameter@sgi.com
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, Mel Gorman <mel@csn.ul.ie>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	William Lee Irwin III <wli@holomorphy.com>
Subject: [patch 5/6] compound pages: Allow use of get_page_unless_zero with compound pages
Date: Thu, 24 May 2007 22:17:21 -0700	[thread overview]
Message-ID: <20070525051947.764986146@sgi.com> (raw)
In-Reply-To: <20070525051716.030494061@sgi.com>

[-- Attachment #1: compound_get_one_unless --]
[-- Type: text/plain, Size: 1154 bytes --]

This will be needed by targeted slab reclaim in order to ensure that a
compound page allocated by SLUB will not go away under us.

It also may be needed if Mel starts to implement defragmentation. The
moving of compound pages may require the establishment of a reference
before the use of page migration functions.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

---
 include/linux/mm.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: slub/include/linux/mm.h
===================================================================
--- slub.orig/include/linux/mm.h	2007-05-24 21:16:14.000000000 -0700
+++ slub/include/linux/mm.h	2007-05-24 21:16:45.000000000 -0700
@@ -293,7 +293,7 @@ static inline int put_page_testzero(stru
  */
 static inline int get_page_unless_zero(struct page *page)
 {
-	VM_BUG_ON(PageCompound(page));
+	VM_BUG_ON(PageTail(page));
 	return atomic_inc_not_zero(&page->_count);
 }
 

-- 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2007-05-25  5:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-25  5:17 [patch 0/6] Compound Page Enhancements clameter
2007-05-25  5:17 ` [patch 1/6] Compound page handling enhancements clameter
2007-05-25  5:17 ` [patch 2/6] compound pages: Add new support functions clameter
2007-05-25  5:17 ` [patch 3/6] compound pages: vmstat support clameter
2007-05-25  5:17 ` [patch 4/6] compound pages: Use new compound vmstat functions in SLUB clameter
2007-05-25  5:17 ` clameter [this message]
2007-05-25  5:17 ` [patch 6/6] compound pages: Allow freeing of compound pages via pagevec clameter
2007-05-25  6:00 ` [patch 0/6] Compound Page Enhancements Andrew Morton
2007-05-25 13:54   ` Christoph Lameter
2007-05-25 14:03   ` Christoph Lameter
2007-05-25 17:14     ` Andrew Morton
2007-05-25 18:56       ` Christoph Lameter
2007-05-25  8:05 ` KAMEZAWA Hiroyuki
2007-05-25 13:42   ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070525051947.764986146@sgi.com \
    --to=clameter@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox