From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: linux-mm <linux-mm@kvack.org>
Subject: [RFC:PATCH 009/012] Wrap i_size_write
Date: Thu, 24 May 2007 08:12:20 -0400 [thread overview]
Message-ID: <20070524121220.13533.54679.sendpatchset@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <20070524121130.13533.32563.sendpatchset@kleikamp.austin.ibm.com>
Wrap i_size_write
If CONFIG_FILE_TAILS is set, i_size_write is defined in file_tail.c
This adds considerable overhead to i_size_write, but i_size_read is unaffected.
Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
---
include/linux/fs.h | 5 +++++
mm/file_tail.c | 12 ++++++++++++
2 files changed, 17 insertions(+)
diff -Nurp linux008/include/linux/fs.h linux009/include/linux/fs.h
--- linux008/include/linux/fs.h 2007-05-23 22:53:11.000000000 -0500
+++ linux009/include/linux/fs.h 2007-05-23 22:53:12.000000000 -0500
@@ -661,7 +661,12 @@ static inline loff_t i_size_read(const s
* (normally i_mutex), otherwise on 32bit/SMP an update of i_size_seqcount
* can be lost, resulting in subsequent i_size_read() calls spinning forever.
*/
+#ifdef CONFIG_VM_FILE_TAILS
+extern void i_size_write(struct inode *, loff_t); /* defined in file_tail.c */
+static inline void _i_size_write(struct inode *inode, loff_t i_size)
+#else
static inline void i_size_write(struct inode *inode, loff_t i_size)
+#endif
{
#if BITS_PER_LONG==32 && defined(CONFIG_SMP)
write_seqcount_begin(&inode->i_size_seqcount);
diff -Nurp linux008/mm/file_tail.c linux009/mm/file_tail.c
--- linux008/mm/file_tail.c 2007-05-23 22:53:11.000000000 -0500
+++ linux009/mm/file_tail.c 2007-05-23 22:53:12.000000000 -0500
@@ -188,6 +188,18 @@ int __unpack_file_tail(struct address_sp
return rc;
}
+void i_size_write(struct inode *inode, loff_t i_size)
+{
+ struct address_space *mapping = inode->i_mapping;
+
+ write_lock_irq(&mapping->tree_lock);
+ if (mapping->tail && (i_size > i_size_read(inode)))
+ __unpack_file_tail(mapping);
+ _i_size_write(inode, i_size);
+ write_unlock_irq(&mapping->tree_lock);
+}
+EXPORT_SYMBOL(i_size_write);
+
static void init_once(void *ptr, struct kmem_cache *cachep, unsigned long flags)
{
struct page *page = (struct page *)ptr;
--
David Kleikamp
IBM Linux Technology Center
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-05-24 12:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 12:11 [RFC:PATCH 000/012] VM Page Tails Dave Kleikamp
2007-05-24 12:11 ` [RFC:PATCH 001/012] Make iommu_map_sg deal with less-than-page-aligned data Dave Kleikamp
2007-05-24 12:11 ` [RFC:PATCH 002/012] Allow file systems to specify whether to store file tails Dave Kleikamp
2007-05-24 12:11 ` [RFC:PATCH 003/012] Add tail to address space and define PG_pagetail page flag Dave Kleikamp
2007-05-24 12:11 ` [RFC:PATCH 004/012] Replace PAGE_CACHE_SIZE with page_data_size() Dave Kleikamp
2007-05-24 12:11 ` [RFC:PATCH 005/012] Base file tail function Dave Kleikamp
2007-05-24 12:12 ` [RFC:PATCH 006/012] Modify lowmem_page_address() & page_to_phys() to special case tail page Dave Kleikamp
2007-05-24 12:12 ` [RFC:PATCH 007/012] Avoid page_to_pfn() on " Dave Kleikamp
2007-05-24 12:12 ` [RFC:PATCH 008/012] bh_offset needs to take page_address into consideration Dave Kleikamp
2007-05-24 12:12 ` Dave Kleikamp [this message]
2007-05-24 12:12 ` [RFC:PATCH 010/012] unpack tail page to avoid memory mapping Dave Kleikamp
2007-05-24 12:12 ` [RFC:PATCH 011/012] Make sure tail page is freed correctly Dave Kleikamp
2007-05-24 12:12 ` [RFC:PATCH 012/012] Add tail hooks into file_map.c Dave Kleikamp
2007-05-24 12:45 ` [RFC:PATCH 000/012] VM File Tails Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070524121220.13533.54679.sendpatchset@kleikamp.austin.ibm.com \
--to=shaggy@linux.vnet.ibm.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox