Re: signals logged / [RFC] log out-of-virtual-memory events

[Folkert van Heusden <folkert@vanheusden.com>]

> > > >>>>I do not see such on i386, so why for x86_64?
> > > >>>So that you know that one of your programs crashed. That's a feature.
> > > >>This feature could be handy for i386 too.
> > > >Since 2.6.18.2 I use this patch. With 2.6.21.1 it still applies altough
> > > >with a small offsets. Works like a charm.
> > > >
> > > >Signed-off by: Folkert van Heusden <folkert@vanheusden.com>
> > > >--- linux-2.6.18.2/kernel/signal.c      2006-11-04 02:33:58.000000000 +0100
> > > >+++ linux-2.6.18.2.new/kernel/signal.c  2006-11-17 15:59:13.000000000 +0100
> > ...
> > > >+                       sig, t -> pid, t -> uid, t -> gid, t -> comm);
> > > 
> > > Please check line 219 of Documentation/CodingStyle, Section 3.1: Spaces
> > > 	and no space around the '.' and "->" structure member operators.
> > New version without the spaces around '->' and a nice 'unlikely' added. 
> > Signed-off by: Folkert van Heusden <folkert@vanheusden.com>
> > --- linux-2.6.18.2/kernel/signal.c	2006-11-04 02:33:58.000000000 +0100
> > +++ linux-2.6.18.2.new/kernel/signal.c	2006-11-17 15:59:13.000000000 +0100
> > @@ -706,6 +706,15 @@
> >  	struct sigqueue * q = NULL;
> >  	int ret = 0;
> >  
> > +	if (unlikely(sig == SIGQUIT || sig == SIGILL  || sig == SIGTRAP ||
> > +	    sig == SIGABRT || sig == SIGBUS  || sig == SIGFPE  ||
> > +	    sig == SIGSEGV || sig == SIGXCPU || sig == SIGXFSZ ||
> > +	    sig == SIGSYS  || sig == SIGSTKFLT))
> > +	{
> > +		printk(KERN_WARNING "Sig %d send to %d owned by %d.%d (%s)\n",
> > +			sig, t->pid, t->uid, t->gid, t->comm);
> > +	}
> > +
> >  	/*
> >  	 * fast-pathed signals for kernel-internal things like SIGSTOP
> >  	 * or SIGKILL.
> 
> Would turning that into a switch() generate better code.

Doubt it: in the worst case you still nee to check for each possibility.
Furthermore a.f.a.i.k. with switch you cannot do 'unlinkely()'.


Folkert van Heusden

-- 
MultiTail er et flexible tool for a kontrolere Logfiles og commandoer.
Med filtrer, farger, sammenforinger, forskeliger ansikter etc.
http://www.vanheusden.com/multitail/
----------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>