From: Nick Piggin <npiggin@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [patch 1/8] mm: fix fault vs invalidate race for linear mappings
Date: Sat, 19 May 2007 03:40:57 +0200 [thread overview]
Message-ID: <20070519014057.GE15569@wotan.suse.de> (raw)
In-Reply-To: <alpine.LFD.0.98.0705180812430.3890@woody.linux-foundation.org>
On Fri, May 18, 2007 at 08:15:27AM -0700, Linus Torvalds wrote:
>
>
> On Fri, 18 May 2007, akpm@linux-foundation.org wrote:
> >
> > Fix the race between invalidate_inode_pages and do_no_page.
>
> Btw, I'm not merging this either. I think it's better done after we have
> flags in the fault info, and people can return "btw, I already locked the
> page for you" as a return value, rather than adding magic flags to
> "vma->vm_flags" to tell the caller how they will behave.
We do have flags in the fault info. Returning that the page is locked is
is probably a good way to go. But that's a very minor change, and I would
prefer such a major bugfix to go into _existing_ code first than introducing
fault first.
Once we drop nopage support, then converting to something saner like that
should be fine.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2007-05-19 1:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-18 7:37 akpm, Nick Piggin
2007-05-18 15:15 ` Linus Torvalds
2007-05-19 1:40 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070519014057.GE15569@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox