From: Andrew Morton <akpm@linux-foundation.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 5/5] Mark page cache pages as __GFP_PAGECACHE instead of __GFP_MOVABLE
Date: Thu, 17 May 2007 12:38:54 -0700 [thread overview]
Message-ID: <20070517123854.6cea6338.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070517101203.3113.81852.sendpatchset@skynet.skynet.ie>
On Thu, 17 May 2007 11:12:03 +0100 (IST)
Mel Gorman <mel@csn.ul.ie> wrote:
> --- linux-2.6.22-rc1-mm1-025_gfphighuser/fs/buffer.c 2007-05-16 22:55:50.000000000 +0100
> +++ linux-2.6.22-rc1-mm1-030_pagecache_mark/fs/buffer.c 2007-05-16 23:07:30.000000000 +0100
> @@ -1009,7 +1009,7 @@ grow_dev_page(struct block_device *bdev,
> struct buffer_head *bh;
>
> page = find_or_create_page(inode->i_mapping, index,
> - GFP_NOFS|__GFP_RECLAIMABLE);
> + GFP_NOFS_PAGECACHE);
> if (!page)
> return NULL;
>
I ended up with
page = find_or_create_page(inode->i_mapping, index,
(mapping_gfp_mask(inode->i_mapping) & ~__GFP_FS)|__GFP_MOVABLE);
here.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-05-17 19:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 10:10 [PATCH 0/5] Annotation fixes for grouping pages by mobility v2 Mel Gorman
2007-05-17 10:10 ` [PATCH 1/5] Mark bio_alloc() allocations correctly Mel Gorman
2007-05-17 10:11 ` [PATCH 2/5] Do not annotate shmem allocations explicitly Mel Gorman
2007-05-17 10:11 ` [PATCH 3/5] Add __GFP_TEMPORARY to identify allocations that are short-lived Mel Gorman
2007-05-17 10:11 ` [PATCH 4/5] Rename GFP_HIGH_MOVABLE to GFP_HIGHUSER_MOVABLE Mel Gorman
2007-05-17 10:12 ` [PATCH 5/5] Mark page cache pages as __GFP_PAGECACHE instead of __GFP_MOVABLE Mel Gorman
2007-05-17 19:38 ` Andrew Morton [this message]
2007-05-18 9:23 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2007-05-16 23:01 [PATCH 0/5] Annotation fixes for grouping pages by mobility Mel Gorman
2007-05-16 23:02 ` [PATCH 5/5] Mark page cache pages as __GFP_PAGECACHE instead of __GFP_MOVABLE Mel Gorman
2007-05-16 23:14 ` Christoph Lameter
2007-05-16 23:19 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070517123854.6cea6338.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox