From: Nishanth Aravamudan <nacc@us.ibm.com>
To: wli@holomorphy.com
Cc: Lee.Schermerhorn@hp.com, anton@samba.org, clameter@sgi.com,
akpm@linux-foundation.org, agl@us.ibm.com, linux-mm@kvack.org
Subject: [PATCH 1/3] hugetlb: remove unnecessary nid initialization
Date: Wed, 16 May 2007 16:30:53 -0700 [thread overview]
Message-ID: <20070516233053.GN20535@us.ibm.com> (raw)
nid is initialized to numa_node_id() but will either be overwritten in
the loop or not used in the conditional. So remove the initialization.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index eb7180d..abcd9a9 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -66,7 +66,7 @@ static void enqueue_huge_page(struct page *page)
static struct page *dequeue_huge_page(struct vm_area_struct *vma,
unsigned long address)
{
- int nid = numa_node_id();
+ int nid;
struct page *page = NULL;
struct zonelist *zonelist = huge_zonelist(vma, address);
struct zone **z;
--
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2007-05-16 23:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 23:30 Nishanth Aravamudan [this message]
2007-05-16 23:31 ` [RFC][PATCH 2/3] hugetlb: numafy several functions Nishanth Aravamudan
2007-05-16 23:33 ` [RFC][PATCH 3/3] hugetlb: add per-node nr_hugepages sysfs attribute Nishanth Aravamudan
2007-05-23 17:51 ` [RFC][PATCH 2/3] hugetlb: numafy several functions Nishanth Aravamudan
2007-05-23 19:16 ` Lee Schermerhorn
2007-05-23 19:29 ` Nishanth Aravamudan
2007-05-25 19:43 ` Nishanth Aravamudan
2007-05-25 20:55 ` Lee Schermerhorn
2007-05-25 21:10 ` Nishanth Aravamudan
2007-05-25 21:39 ` Andrew Morton
2007-05-25 21:47 ` Lee Schermerhorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070516233053.GN20535@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=agl@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anton@samba.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox