From: mel@skynet.ie (Mel Gorman)
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH 5/5] Mark page cache pages as __GFP_PAGECACHE instead of __GFP_MOVABLE
Date: Thu, 17 May 2007 00:19:26 +0100 [thread overview]
Message-ID: <20070516231926.GA7340@skynet.ie> (raw)
In-Reply-To: <Pine.LNX.4.64.0705161613280.12119@schroedinger.engr.sgi.com>
On (16/05/07 16:14), Christoph Lameter didst pronounce:
> On Thu, 17 May 2007, Mel Gorman wrote:
>
> > diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.22-rc1-mm1-025_gfphighuser/fs/block_dev.c linux-2.6.22-rc1-mm1-030_pagecache_mark/fs/block_dev.c
> > --- linux-2.6.22-rc1-mm1-025_gfphighuser/fs/block_dev.c 2007-05-16 10:54:18.000000000 +0100
> > +++ linux-2.6.22-rc1-mm1-030_pagecache_mark/fs/block_dev.c 2007-05-16 23:07:30.000000000 +0100
> > @@ -576,7 +576,7 @@ struct block_device *bdget(dev_t dev)
> > inode->i_rdev = dev;
> > inode->i_bdev = bdev;
> > inode->i_data.a_ops = &def_blk_aops;
> > - mapping_set_gfp_mask(&inode->i_data, GFP_USER|__GFP_MOVABLE);
> > + mapping_set_gfp_mask(&inode->i_data, GFP_USER);
> > inode->i_data.backing_dev_info = &default_backing_dev_info;
> > spin_lock(&bdev_lock);
> > list_add(&bdev->bd_list, &all_bdevs);
> > diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.22-rc1-mm1-025_gfphighuser/fs/buffer.c linux-2.6.22-rc1-mm1-030_pagecache_mark/fs/buffer.c
> > --- linux-2.6.22-rc1-mm1-025_gfphighuser/fs/buffer.c 2007-05-16 22:55:50.000000000 +0100
> > +++ linux-2.6.22-rc1-mm1-030_pagecache_mark/fs/buffer.c 2007-05-16 23:07:30.000000000 +0100
> > @@ -1009,7 +1009,7 @@ grow_dev_page(struct block_device *bdev,
> > struct buffer_head *bh;
> >
> > page = find_or_create_page(inode->i_mapping, index,
> > - GFP_NOFS|__GFP_RECLAIMABLE);
> > + GFP_NOFS_PAGECACHE);
> > if (!page)
> > return NULL;
> >
>
> We still have the contrast here. Should fs/block_dev.c not have
> GFP_PAGECACHE?
It's not clear where, if anywhere, that pages allocated using the
mapping_set_gfp_mask() from bdget() end up on an LRU or become otherwise
movable. Hence, I removed the flag until such time as I am sure.
> But you could leave it and then my patch could fix this
> up.
>
Perfect.
> Otherwise
>
> Acked-by: Christoph Lameter <clameter@sgi.com>
Thanks.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-05-16 23:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 23:01 [PATCH 0/5] Annotation fixes for grouping pages by mobility Mel Gorman
2007-05-16 23:01 ` [PATCH 1/5] Mark bio_alloc() allocations correctly Mel Gorman
2007-05-16 23:11 ` Christoph Lameter
2007-05-16 23:01 ` [PATCH 2/5] Do not annotate shmem allocations explicitly Mel Gorman
2007-05-16 23:12 ` Christoph Lameter
2007-05-16 23:02 ` [PATCH 3/5] Add __GFP_TEMPORARY to identify allocations that are short-lived Mel Gorman
2007-05-16 23:02 ` [PATCH 4/5] Rename GFP_HIGH_MOVABLE to GFP_HIGHUSER_MOVABLE Mel Gorman
2007-05-16 23:02 ` [PATCH 5/5] Mark page cache pages as __GFP_PAGECACHE instead of __GFP_MOVABLE Mel Gorman
2007-05-16 23:14 ` Christoph Lameter
2007-05-16 23:19 ` Mel Gorman [this message]
2007-05-17 10:10 [PATCH 0/5] Annotation fixes for grouping pages by mobility v2 Mel Gorman
2007-05-17 10:12 ` [PATCH 5/5] Mark page cache pages as __GFP_PAGECACHE instead of __GFP_MOVABLE Mel Gorman
2007-05-17 19:38 ` Andrew Morton
2007-05-18 9:23 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070516231926.GA7340@skynet.ie \
--to=mel@skynet.ie \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox