From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 14 May 2007 15:00:32 -0700 From: Andrew Morton Subject: Re: [PATCH] mm: swap prefetch more improvements Message-Id: <20070514150032.d3ef6bb1.akpm@linux-foundation.org> In-Reply-To: <200705141050.55038.kernel@kolivas.org> References: <200705141050.55038.kernel@kolivas.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Con Kolivas Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, ck@vds.kolivas.org List-ID: On Mon, 14 May 2007 10:50:54 +1000 Con Kolivas wrote: > akpm, please queue on top of "mm: swap prefetch improvements" > > --- > Failed radix_tree_insert wasn't being handled leaving stale kmem. > > The list should be iterated over in the reverse order when prefetching. > > Make the yield within kprefetchd stronger through the use of cond_resched. hm. > > - might_sleep(); > - if (!prefetch_suitable()) > + /* Yield to anything else running */ > + if (cond_resched() || !prefetch_suitable()) > goto out_unlocked; So if cond_resched() happened to schedule away, we terminate this swap-tricking attempt. It's not possible to determine the reasons for this from the code or from the changelog (==bad). How come? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org