From: Andrew Morton <akpm@linux-foundation.org>
To: Con Kolivas <kernel@kolivas.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, ck@vds.kolivas.org
Subject: Re: [PATCH] mm: swap prefetch more improvements
Date: Mon, 14 May 2007 15:00:32 -0700 [thread overview]
Message-ID: <20070514150032.d3ef6bb1.akpm@linux-foundation.org> (raw)
In-Reply-To: <200705141050.55038.kernel@kolivas.org>
On Mon, 14 May 2007 10:50:54 +1000
Con Kolivas <kernel@kolivas.org> wrote:
> akpm, please queue on top of "mm: swap prefetch improvements"
>
> ---
> Failed radix_tree_insert wasn't being handled leaving stale kmem.
>
> The list should be iterated over in the reverse order when prefetching.
>
> Make the yield within kprefetchd stronger through the use of cond_resched.
hm.
>
> - might_sleep();
> - if (!prefetch_suitable())
> + /* Yield to anything else running */
> + if (cond_resched() || !prefetch_suitable())
> goto out_unlocked;
So if cond_resched() happened to schedule away, we terminate this
swap-tricking attempt. It's not possible to determine the reasons for this
from the code or from the changelog (==bad).
How come?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-05-14 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-14 0:50 Con Kolivas
2007-05-14 22:00 ` Andrew Morton [this message]
2007-05-14 22:43 ` Con Kolivas
2007-05-14 23:01 ` Andrew Morton
2007-05-14 23:24 ` Con Kolivas
2007-05-14 23:37 ` [ck] " Michael Chang
2007-05-15 9:58 ` Peter Zijlstra
2007-05-15 12:43 ` Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070514150032.d3ef6bb1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ck@vds.kolivas.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox