From: Fengguang Wu <fengguang.wu@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Rik van Riel <riel@redhat.com>, Theodore Ts'o <tytso@mit.edu>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] resolve duplicate flag no for PG_lazyfree
Date: Mon, 14 May 2007 15:55:20 +0800 [thread overview]
Message-ID: <379129320.24602@ustc.edu.cn> (raw)
Message-ID: <20070514075519.GA6255@mail.ustc.edu.cn> (raw)
In-Reply-To: <20070513224630.3cd0cb54.akpm@linux-foundation.org>
On Sun, May 13, 2007 at 10:46:30PM -0700, Andrew Morton wrote:
> On Mon, 14 May 2007 10:37:18 +0800 Fengguang Wu <fengguang.wu@gmail.com> wrote:
>
> > PG_lazyfree and PG_booked shares the same bit.
> >
> > Either it is a bug that shall fixed by the following patch, or
> > the situation should be explicitly documented?
> >
> > Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
> > ---
> > include/linux/page-flags.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-2.6.21-mm2.orig/include/linux/page-flags.h
> > +++ linux-2.6.21-mm2/include/linux/page-flags.h
> > @@ -91,7 +91,7 @@
> > #define PG_buddy 19 /* Page is free, on buddy lists */
> > #define PG_booked 20 /* Has blocks reserved on-disk */
> >
> > -#define PG_lazyfree 20 /* MADV_FREE potential throwaway */
> > +#define PG_lazyfree 21 /* MADV_FREE potential throwaway */
> >
> > /* PG_owner_priv_1 users should have descriptive aliases */
> > #define PG_checked PG_owner_priv_1 /* Used by some filesystems */
>
> That's an accident: PG_lazyfree got added but the out-of-tree ext4 patches
> didn't get updated.
>
> otoh, the intersection between pages which are PageBooked() and pages which
> are PageLazyFree() should be zreo, so it'd be good to actually formalise
> this reuse within the ext4 patches.
>
> otoh2, PageLazyFree() could have reused PG_owner_priv_1.
otoh3: PG_lazyfree and PG_readahead can reuse the same bit, too.
PG_lazyfree applies to anonymous pages, while PG_readahead applies to
file backed pages.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID
From: Fengguang Wu <fengguang.wu@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Rik van Riel <riel@redhat.com>, Theodore Ts'o <tytso@mit.edu>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] resolve duplicate flag no for PG_lazyfree
Date: Mon, 14 May 2007 15:55:20 +0800 [thread overview]
Message-ID: <20070514075519.GA6255__32494.7182824419$1179129837$gmane$org@mail.ustc.edu.cn> (raw)
Message-ID: <20070514075519.GA6255@mail.ustc.edu.cn> (raw)
In-Reply-To: <20070513224630.3cd0cb54.akpm@linux-foundation.org>
On Sun, May 13, 2007 at 10:46:30PM -0700, Andrew Morton wrote:
> On Mon, 14 May 2007 10:37:18 +0800 Fengguang Wu <fengguang.wu@gmail.com> wrote:
>
> > PG_lazyfree and PG_booked shares the same bit.
> >
> > Either it is a bug that shall fixed by the following patch, or
> > the situation should be explicitly documented?
> >
> > Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
> > ---
> > include/linux/page-flags.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-2.6.21-mm2.orig/include/linux/page-flags.h
> > +++ linux-2.6.21-mm2/include/linux/page-flags.h
> > @@ -91,7 +91,7 @@
> > #define PG_buddy 19 /* Page is free, on buddy lists */
> > #define PG_booked 20 /* Has blocks reserved on-disk */
> >
> > -#define PG_lazyfree 20 /* MADV_FREE potential throwaway */
> > +#define PG_lazyfree 21 /* MADV_FREE potential throwaway */
> >
> > /* PG_owner_priv_1 users should have descriptive aliases */
> > #define PG_checked PG_owner_priv_1 /* Used by some filesystems */
>
> That's an accident: PG_lazyfree got added but the out-of-tree ext4 patches
> didn't get updated.
>
> otoh, the intersection between pages which are PageBooked() and pages which
> are PageLazyFree() should be zreo, so it'd be good to actually formalise
> this reuse within the ext4 patches.
>
> otoh2, PageLazyFree() could have reused PG_owner_priv_1.
otoh3: PG_lazyfree and PG_readahead can reuse the same bit, too.
PG_lazyfree applies to anonymous pages, while PG_readahead applies to
file backed pages.
next prev parent reply other threads:[~2007-05-14 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <379110250.28666@ustc.edu.cn>
2007-05-14 5:46 ` Andrew Morton
[not found] ` <20070514075519.GA6255@mail.ustc.edu.cn>
2007-05-14 7:55 ` Fengguang Wu [this message]
2007-05-14 7:55 ` Fengguang Wu
2007-05-14 18:06 ` Theodore Tso
2007-05-14 20:46 ` Andrew Morton
2007-05-16 0:28 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=379129320.24602@ustc.edu.cn \
--to=fengguang.wu@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox