linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: David Howells <dhowells@redhat.com>
Cc: Christoph Lameter <clameter@sgi.com>,
	linux-mm@kvack.org, akpm@linux-foundation.org
Subject: Re: Get FRV to be able to run SLUB
Date: Tue, 8 May 2007 20:59:33 +0900	[thread overview]
Message-ID: <20070508115933.GA15074@linux-sh.org> (raw)
In-Reply-To: <7950.1178620309@redhat.com>

On Tue, May 08, 2007 at 11:31:49AM +0100, David Howells wrote:
> Christoph Lameter <clameter@sgi.com> wrote:
> Missing header file inclusion.
> 
> > +	pgd = quicklist_free(0, NULL, pgd_dtor);
> 
> That function is void, and is should be passed pgd or something, but I'm not
> sure what.  No other arch seems to use this.
> 
sparc64 uses it now, and others are moving over to it gradually (I just
converted SH earlier). pgd_free() should be:

	quicklist_free(0, pgd_dtor, pgd);

in this case.

include/linux/quicklist.h isn't exactly lacking for documentation.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-05-08 11:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-08  3:41 Christoph Lameter
2007-05-08 10:31 ` David Howells
2007-05-08 11:59   ` Paul Mundt [this message]
2007-05-08 12:04   ` David Howells
2007-05-08 16:05   ` Christoph Lameter
2007-05-08 18:02   ` David Howells
2007-05-08 18:07     ` Christoph Lameter
2007-05-08 19:52     ` David Howells
2007-05-08 20:28       ` Christoph Lameter
2007-05-08 20:33       ` Christoph Lameter
2007-05-09  9:23       ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070508115933.GA15074@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=dhowells@redhat.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox