linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mel@csn.ul.ie>
To: clameter@sgi.com
Cc: Mel Gorman <mel@csn.ul.ie>, linux-mm@kvack.org
Subject: [PATCH 0/4] Clarify GFP flag usage when grouping pages by mobility
Date: Mon, 30 Apr 2007 19:55:24 +0100 (IST)	[thread overview]
Message-ID: <20070430185524.7142.56162.sendpatchset@skynet.skynet.ie> (raw)

Hi Christoph,

The following patches are the starting point for addressing points brought
up by your review of the grouping pages by mobility patches.  The main
intention of the patches are to make the usage of GFP flags that group pages
by mobility clearer.

The first patch fixes a problem on m68knommu where
alloc_zeroed_user_highpage_movable() was not fixed up properly. This is a
bug fix that was found while developing the second patch. It needs to be
applied regardless of the remaining patches so I'll be pushing this separetly.

The second patch removes alloc_zeroed_user_highpage() as there
are no in-tree users. External users should be migrated to use
alloc_zeroed_user_highpage_movable(). The function is not marked deprecated
because it was not generating the appropriate gcc warnings.

The third patch uses SLAB_ACCOUNT_RECLAIM to determine when __GFP_RECLAIMABLE
should be used instead of updating individual call sites.

The final patch defines __GFP_TEMPORARY, GFP_TEMPORARY and SLAB_TEMPORARY
for short-lived allocations. Currently __GFP_RECLAIMABLE is used to mean
both reclaimable and short-lived which can be confusing when reading the
call-sites using __GFP_RECLAIMABLE. This patch does not change the final
destination for the pages, but clarifies the callers intent should we wish
to change it later.

Credit goes to Andy Whitcroft for reviewing these before sending out.

Regression tests are currently underway but the risk should be low as
there is no functionalty change as such. Two tests on x86_64 have completed
successfully and I see no reason why any other machine will fail. Please review.

Thanks a lot for your time.
-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2007-04-30 18:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-30 18:55 Mel Gorman [this message]
2007-04-30 18:55 ` [PATCH 1/4] Fix alloc_zeroed_user_highpage on m68knommu Mel Gorman
2007-04-30 18:56 ` [PATCH 2/4] Remove alloc_zeroed_user_highpage() Mel Gorman
2007-04-30 18:56 ` [PATCH 3/4] Use SLAB_ACCOUNT_RECLAIM to determine when __GFP_RECLAIMABLE should be used Mel Gorman
2007-04-30 19:02   ` Christoph Lameter
2007-04-30 18:56 ` [PATCH 4/4] Add __GFP_TEMPORARY to identify allocations that are short-lived Mel Gorman
2007-04-30 19:08   ` Christoph Lameter
2007-04-30 19:44     ` Mel Gorman
2007-04-30 19:52       ` Christoph Lameter
2007-04-30 20:11         ` Mel Gorman
2007-04-30 20:14           ` Christoph Lameter
2007-04-30 20:33             ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070430185524.7142.56162.sendpatchset@skynet.skynet.ie \
    --to=mel@csn.ul.ie \
    --cc=clameter@sgi.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox