From: Andrew Morton <akpm@linux-foundation.org>
To: "Vladimir V. Saveliev" <vs@namesys.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
linux-kernel@vger.kernel.org, linux-aio@kvack.org,
reiserfs-dev@namesys.com, linux-mm@kvack.org
Subject: Re: dio_get_page() lockdep complaints
Date: Thu, 19 Apr 2007 09:42:54 -0700 [thread overview]
Message-ID: <20070419094254.2b273d0c.akpm@linux-foundation.org> (raw)
In-Reply-To: <200704191857.42001.vs@namesys.com>
On Thu, 19 Apr 2007 18:57:41 +0400 "Vladimir V. Saveliev" <vs@namesys.com> wrote:
> > It's a bit odd that reiserfs is playing with file contents within
> > file_operations.release(): there could be other files open against that
> > inode. One would expect this sort of thing to be happening in an
> > inode_operation. But it's been like that for a long time.
> >
>
> reiserfs needs to "pack" file tail when last process which opened a file closes it.
> Can you see more suitable place where that could be performed?
No, you're right - I got my ->release() and ->flush() mixed up.
Possibly one could perform this operation on the final iput(), but I suspect the
locking situation there would be even more complex.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-04-19 16:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070419073828.GB20928@kernel.dk>
2007-04-19 8:01 ` Andrew Morton
2007-04-19 8:01 ` Jens Axboe
2007-04-19 8:25 ` Andrew Morton
2007-04-19 8:34 ` Jens Axboe
2007-04-19 12:43 ` Vladimir V. Saveliev
2007-04-19 12:49 ` Jens Axboe
2007-04-19 12:52 ` Jens Axboe
2007-04-19 13:53 ` Roland Dreier
2007-04-19 14:20 ` Jens Axboe
2007-04-19 14:15 ` Jens Axboe
2007-04-19 14:55 ` Vladimir V. Saveliev
2007-04-19 14:57 ` Vladimir V. Saveliev
2007-04-19 16:42 ` Andrew Morton [this message]
2007-04-19 14:36 ` Chris Mason
[not found] ` <1194627742.6289.175.camel@twins>
[not found] ` <4734992C.7000408@oracle.com>
[not found] ` <1194630300.7459.65.camel@heimdal.trondhjem.org>
2007-11-11 19:49 ` Peter Zijlstra
2007-11-12 8:45 ` Martin Schwidefsky
2007-11-12 9:27 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070419094254.2b273d0c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=reiserfs-dev@namesys.com \
--cc=vs@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox