From mboxrd@z Thu Jan  1 00:00:00 1970
Date: Tue, 17 Apr 2007 17:12:13 +0200
From: Eric Dumazet <dada1@cosmosbay.com>
Subject: Re: [PATCH] Show slab memory usage on OOM and SysRq-M
Message-Id: <20070417171213.e3cbc260.dada1@cosmosbay.com>
In-Reply-To: <84144f020704170622h2b16f0f6m47ffdbb3b5686758@mail.gmail.com>
References: <4624C3C1.9040709@sw.ru>
	<84144f020704170622h2b16f0f6m47ffdbb3b5686758@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-linux-mm@kvack.org
Return-Path: <owner-linux-mm@kvack.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Pavel Emelianov <xemul@sw.ru>, Andrew Morton <akpm@osdl.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, devel@openvz.org, Kirill Korotaev <dev@openvz.org>, linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>

On Tue, 17 Apr 2007 16:22:48 +0300
"Pekka Enberg" <penberg@cs.helsinki.fi> wrote:

> Hi,
> 
> On 4/17/07, Pavel Emelianov <xemul@sw.ru> wrote:
> > +static unsigned long get_cache_size(struct kmem_cache *cachep)
> > +{
> > +       unsigned long slabs;
> > +       struct kmem_list3 *l3;
> > +       struct list_head *lh;
> > +       int node;
> > +
> > +       slabs = 0;
> > +
> > +       for_each_online_node (node) {
> > +               l3 = cachep->nodelists[node];
> > +               if (l3 == NULL)
> > +                       continue;
> > +
> > +               spin_lock(&l3->list_lock);
> > +               list_for_each (lh, &l3->slabs_full)
> > +                       slabs++;
> > +               list_for_each (lh, &l3->slabs_partial)
> > +                       slabs++;
> > +               list_for_each (lh, &l3->slabs_free)
> > +                       slabs++;
> > +               spin_unlock(&l3->list_lock);
> > +       }
> > +
> > +       return slabs * ((PAGE_SIZE << cachep->gfporder) +
> > +               (OFF_SLAB(cachep) ? cachep->slabp_cache->buffer_size : 0));
> > +}
> 
> Considering you're doing this at out_of_memory() time, wouldn't it
> make more sense to add a ->nr_pages to struct kmem_cache and do the
> tracking in kmem_getpages/kmem_freepages?
> 

To avoid a deadlock ? yes...

This nr_pages should be in struct kmem_list3, not in struct kmem_cache, or else you defeat NUMA optimizations if touching a field in kmem_cache at kmem_getpages()/kmem_freepages() time.

       for_each_online_node (node) {
               l3 = cachep->nodelists[node];
               if (l3)
                   slabs += l3->nr_pages; /* dont lock l3->list_lock */
       }

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>