From: Christoph Lameter <clameter@sgi.com>
To: akpm@osdl.org
Cc: linux-mm@kvack.org, Christoph Lameter <clameter@sgi.com>
Subject: [SLUB 1/5] Fix validation
Date: Thu, 12 Apr 2007 18:36:33 -0700 (PDT) [thread overview]
Message-ID: <20070413013633.17093.93334.sendpatchset@schroedinger.engr.sgi.com> (raw)
Some parts of object validation will never occur because on_freelist
does return the wrong exit code for a NULL object.
Fix that.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Index: linux-2.6.21-rc6/mm/slub.c
===================================================================
--- linux-2.6.21-rc6.orig/mm/slub.c 2007-04-12 15:06:54.000000000 -0700
+++ linux-2.6.21-rc6/mm/slub.c 2007-04-12 15:07:23.000000000 -0700
@@ -588,7 +588,7 @@ static int on_freelist(struct kmem_cache
s->objects - nr);
page->inuse = s->objects - nr;
}
- return 0;
+ return search == NULL;
}
/*
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2007-04-13 1:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-13 1:36 Christoph Lameter [this message]
2007-04-13 1:36 ` [SLUB 2/5] Add after object padding Christoph Lameter
2007-04-13 1:36 ` [SLUB 3/5] Remove object activities out of checking functions Christoph Lameter
2007-04-13 1:36 ` [SLUB 4/5] Resiliency fixups Christoph Lameter
2007-04-13 1:58 ` Christoph Lameter
2007-04-13 1:36 ` [SLUB 5/5] Resiliency test Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070413013633.17093.93334.sendpatchset@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox