linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mel@csn.ul.ie>
To: akpm@linux-foundation.org
Cc: Mel Gorman <mel@csn.ul.ie>, linux-mm@kvack.org
Subject: [PATCH 4/4] Do not block align PFN when looking up the pageblock PFN
Date: Tue, 10 Apr 2007 17:04:04 +0100 (IST)	[thread overview]
Message-ID: <20070410160404.10742.4024.sendpatchset@skynet.skynet.ie> (raw)
In-Reply-To: <20070410160244.10742.42187.sendpatchset@skynet.skynet.ie>

The pageblock flags store bits representing a MAX_ORDER_NR_PAGES block of
pages. When calling get_pageblock_bitmap(), a non-aligned PFN is passed
which is then aligned to the MAX_ORDER_NR_PAGES block. This alignment
is unnecessary.

This patch should be considered a fix to the patch
add-a-bitmap-that-is-used-to-track-flags-affecting-a-block-of-pages.patch .

Signed-off-by: Mel Gorman <mel@csn.ul.ie>
Acked-by: Andy Whitcroft <apw@shadowen.org>
---

 page_alloc.c |    4 +---
 1 files changed, 1 insertion(+), 3 deletions(-)

diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.21-rc6-mm1-003_streamline_percpu/mm/page_alloc.c linux-2.6.21-rc6-mm1-004_noblockpfn_sparsemem/mm/page_alloc.c
--- linux-2.6.21-rc6-mm1-003_streamline_percpu/mm/page_alloc.c	2007-04-10 11:35:34.000000000 +0100
+++ linux-2.6.21-rc6-mm1-004_noblockpfn_sparsemem/mm/page_alloc.c	2007-04-10 11:37:28.000000000 +0100
@@ -4169,9 +4169,7 @@ static inline unsigned long *get_pageblo
 							unsigned long pfn)
 {
 #ifdef CONFIG_SPARSEMEM
-	unsigned long blockpfn;
-	blockpfn = pfn & ~(MAX_ORDER_NR_PAGES - 1);
-	return __pfn_to_section(blockpfn)->pageblock_flags;
+	return __pfn_to_section(pfn)->pageblock_flags;
 #else
 	return zone->pageblock_flags;
 #endif /* CONFIG_SPARSEMEM */

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      parent reply	other threads:[~2007-04-10 16:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-10 16:02 [PATCH 0/4] Updates to groupings pages by mobility patches Mel Gorman
2007-04-10 16:03 ` [PATCH 1/4] Remove unnecessary check for MIGRATE_RESERVE during boot Mel Gorman
2007-04-10 16:03 ` [PATCH 2/4] Do not group pages by mobility type on low memory systems Mel Gorman
2007-04-10 16:03 ` [PATCH 3/4] Reduce the amount of time spent in the per-cpu allocator Mel Gorman
2007-04-10 16:04 ` Mel Gorman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070410160404.10742.4024.sendpatchset@skynet.skynet.ie \
    --to=mel@csn.ul.ie \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox