From: Mel Gorman <mel@csn.ul.ie>
To: akpm@linux-foundation.org
Cc: Mel Gorman <mel@csn.ul.ie>, linux-mm@kvack.org
Subject: [PATCH 1/4] Remove unnecessary check for MIGRATE_RESERVE during boot
Date: Tue, 10 Apr 2007 17:03:04 +0100 (IST) [thread overview]
Message-ID: <20070410160304.10742.57011.sendpatchset@skynet.skynet.ie> (raw)
In-Reply-To: <20070410160244.10742.42187.sendpatchset@skynet.skynet.ie>
At boot time, a number of MAX_ORDER_NR_PAGES get marked MIGRATE_RESERVE and
the remainder get marked MIGRATE_MOVABLE. The blocks are marked MOVABLE in
memmap_init_zone() before any blocks are marked reserve. A check is made in
memmap_init_zone() for (get_pageblock_migratetype(page) != MIGRATE_RESERVE)
which is a waste of time because the reserve has not been set yet. This
oversight was because an early version of the MIGRATE_RESERVE patch set
blocks MIGRATE_RESERVE earlier. This patch gets rid of the redundant check.
This should be considered a fix for
bias-the-location-of-pages-freed-for-min_free_kbytes-in-the-same-max_order_nr_pages-blocks.patch
Signed-off-by: Mel Gorman <mel@csn.ul.ie>
Acked-by: Andy Whitcroft <apw@shadowen.org>
---
page_alloc.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.21-rc6-mm1-clean/mm/page_alloc.c linux-2.6.21-rc6-mm1-001_remove_unnecessary_check/mm/page_alloc.c
--- linux-2.6.21-rc6-mm1-clean/mm/page_alloc.c 2007-04-09 23:26:16.000000000 +0100
+++ linux-2.6.21-rc6-mm1-001_remove_unnecessary_check/mm/page_alloc.c 2007-04-09 23:27:58.000000000 +0100
@@ -2468,8 +2468,7 @@ void __meminit memmap_init_zone(unsigned
* the start are marked MIGRATE_RESERVE by
* setup_zone_migrate_reserve()
*/
- if ((pfn & (MAX_ORDER_NR_PAGES-1)) == 0 &&
- get_pageblock_migratetype(page) != MIGRATE_RESERVE)
+ if ((pfn & (MAX_ORDER_NR_PAGES-1)))
set_pageblock_migratetype(page, MIGRATE_MOVABLE);
INIT_LIST_HEAD(&page->lru);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-04-10 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 16:02 [PATCH 0/4] Updates to groupings pages by mobility patches Mel Gorman
2007-04-10 16:03 ` Mel Gorman [this message]
2007-04-10 16:03 ` [PATCH 2/4] Do not group pages by mobility type on low memory systems Mel Gorman
2007-04-10 16:03 ` [PATCH 3/4] Reduce the amount of time spent in the per-cpu allocator Mel Gorman
2007-04-10 16:04 ` [PATCH 4/4] Do not block align PFN when looking up the pageblock PFN Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070410160304.10742.57011.sendpatchset@skynet.skynet.ie \
--to=mel@csn.ul.ie \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox