From: Christoph Lameter <clameter@sgi.com>
To: akpm@osdl.org
Cc: linux-mm@kvack.org, Christoph Lameter <clameter@sgi.com>
Subject: [SLUB 1/5] Minor fixes
Date: Mon, 9 Apr 2007 20:29:12 -0700 (PDT) [thread overview]
Message-ID: <20070410032912.18967.67076.sendpatchset@schroedinger.engr.sgi.com> (raw)
1. Correct spelling
2. Partial pages should go to the front of the partial list since they are
cache hot.
3. Remove stray printk.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Index: linux-2.6.21-rc6-mm1/mm/slub.c
===================================================================
--- linux-2.6.21-rc6-mm1.orig/mm/slub.c 2007-04-09 15:29:14.000000000 -0700
+++ linux-2.6.21-rc6-mm1/mm/slub.c 2007-04-09 18:19:56.000000000 -0700
@@ -277,7 +277,7 @@ static void print_track(const char *s, s
} else
#endif
printk(KERN_ERR "%s: 0x%p", s, t->addr);
- printk(" jiffies since=%lu cpu=%u pid=%d\n", jiffies - t->when, t->cpu, t->pid);
+ printk(" jiffies_ago=%lu cpu=%u pid=%d\n", jiffies - t->when, t->cpu, t->pid);
}
static void print_trailer(struct kmem_cache *s, u8 *p)
@@ -579,7 +579,7 @@ static int alloc_object_checks(struct km
goto bad;
if (object && !on_freelist(s, page, object)) {
- printk(KERN_ERR "SLAB: %s Object 0x%p@0x%p "
+ printk(KERN_ERR "SLUB: %s Object 0x%p@0x%p "
"already allocated.\n",
s->name, object, page);
goto dump;
@@ -862,7 +862,7 @@ static void add_partial(struct kmem_cach
spin_lock(&n->list_lock);
n->nr_partial++;
- list_add_tail(&page->lru, &n->partial);
+ list_add(&page->lru, &n->partial);
spin_unlock(&n->list_lock);
}
@@ -2507,7 +2507,6 @@ static ssize_t trace_store(struct kmem_c
size_t length)
{
s->flags &= ~SLAB_TRACE;
- printk("_trace_store = %s\n", buf);
if (buf[0] == '1')
s->flags |= SLAB_TRACE;
return length;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2007-04-10 3:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 3:29 Christoph Lameter [this message]
2007-04-10 3:29 ` [SLUB 2/5] Use enum for tracking modes instead of integers Christoph Lameter
2007-04-10 3:29 ` [SLUB 3/5] Fix object tracking Christoph Lameter
2007-04-10 3:29 ` [SLUB 4/5] Fix another NUMA bootstrap issue Christoph Lameter
2007-04-10 3:29 ` [SLUB 5/5] Update slabinfo.c Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070410032912.18967.67076.sendpatchset@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox