From: Andi Kleen <ak@suse.de>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [QUICKLIST 3/4] Quicklist support for x86_64
Date: Mon, 9 Apr 2007 20:43:14 +0200 [thread overview]
Message-ID: <200704092043.14335.ak@suse.de> (raw)
In-Reply-To: <20070409182520.8559.33529.sendpatchset@schroedinger.engr.sgi.com>
On Monday 09 April 2007 20:25:20 Christoph Lameter wrote:
> #endif /* _X86_64_PGALLOC_H */
> Index: linux-2.6.21-rc5-mm4/arch/x86_64/kernel/process.c
> ===================================================================
> --- linux-2.6.21-rc5-mm4.orig/arch/x86_64/kernel/process.c 2007-04-07 18:07:47.000000000 -0700
> +++ linux-2.6.21-rc5-mm4/arch/x86_64/kernel/process.c 2007-04-07 18:09:30.000000000 -0700
> @@ -207,6 +207,7 @@
> if (__get_cpu_var(cpu_idle_state))
> __get_cpu_var(cpu_idle_state) = 0;
>
> + check_pgt_cache();
Wouldn't it be better to do that on memory pressure only (register
it as a shrinker)?
> rmb();
> idle = pm_idle;
> if (!idle)
> Index: linux-2.6.21-rc5-mm4/arch/x86_64/kernel/smp.c
> ===================================================================
> --- linux-2.6.21-rc5-mm4.orig/arch/x86_64/kernel/smp.c 2007-04-07 18:07:47.000000000 -0700
> +++ linux-2.6.21-rc5-mm4/arch/x86_64/kernel/smp.c 2007-04-07 18:09:30.000000000 -0700
> @@ -241,7 +241,7 @@
> }
> if (!cpus_empty(cpu_mask))
> flush_tlb_others(cpu_mask, mm, FLUSH_ALL);
> -
> + check_pgt_cache();
Why is that here?
> preempt_enable();
> }
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-04-09 18:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-09 18:25 [QUICKLIST 1/4] Quicklists for page table pages V5 Christoph Lameter
2007-04-09 18:25 ` [QUICKLIST 2/4] Quicklist support for IA64 Christoph Lameter
2007-04-09 18:25 ` [QUICKLIST 3/4] Quicklist support for x86_64 Christoph Lameter
2007-04-09 18:43 ` Andi Kleen [this message]
2007-04-09 18:46 ` Christoph Lameter
2007-04-09 18:49 ` Andi Kleen
2007-04-09 18:51 ` Christoph Lameter
2007-04-09 18:53 ` Andi Kleen
2007-04-09 18:56 ` Christoph Lameter
2007-04-09 21:28 ` Andrew Morton
2007-04-09 22:01 ` Christoph Lameter
2007-04-09 18:25 ` [QUICKLIST 4/4] Quicklist support for sparc64 Christoph Lameter, David Miller
2007-04-09 18:48 ` [QUICKLIST 1/4] Quicklists for page table pages V5 Andrew Morton
2007-04-09 18:50 ` Christoph Lameter
2007-04-09 21:27 ` Andrew Morton
2007-04-09 21:41 ` Andrew Morton
2007-04-09 22:03 ` Christoph Lameter
2007-04-10 0:26 ` William Lee Irwin III
2007-04-10 0:53 ` Christoph Lameter
2007-04-10 4:45 ` Benjamin Herrenschmidt
2007-04-11 4:04 ` Christoph Lameter
2007-04-11 4:18 ` Benjamin Herrenschmidt
2007-04-11 5:41 ` Paul Mackerras
2007-04-11 6:15 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704092043.14335.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox